Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment curl #4817

Merged
merged 2 commits into from
Jan 22, 2020
Merged

comment curl #4817

merged 2 commits into from
Jan 22, 2020

Conversation

daixiang0
Copy link
Contributor

Signed-off-by: Xiang Dai 764524258@qq.com

If there is no golangci-cli or curl, build would fail:

npm WARN lifecycle kubernetes-dashboard@2.0.0-beta4~postinstall: cannot run in wd kubernetes-dashboard@2.0.0-beta4 node aio/scripts/version.js && command -v golangci-lint >/dev/
null 2>&1 || { curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(go env GOPATH)/bin v1.17.1; } && go mod download (wd=/app)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 22, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2020
@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #4817 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4817   +/-   ##
=======================================
  Coverage   45.43%   45.43%           
=======================================
  Files         214      214           
  Lines        9977     9977           
  Branches       94       94           
=======================================
  Hits         4533     4533           
  Misses       5180     5180           
  Partials      264      264

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d22c869...8cc0cab. Read the comment docs.

Signed-off-by: Xiang Dai <764524258@qq.com>
@floreks
Copy link
Member

floreks commented Jan 22, 2020

Please add curl to the top as required dependency.

Signed-off-by: Xiang Dai <764524258@qq.com>
@daixiang0
Copy link
Contributor Author

@floreks done

@floreks
Copy link
Member

floreks commented Jan 22, 2020

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daixiang0, floreks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit 880bccc into kubernetes:master Jan 22, 2020
@daixiang0 daixiang0 deleted the curl branch January 23, 2020 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants