Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set MinVersion for TLS #5013

Merged
merged 1 commit into from
Mar 19, 2020
Merged

Set MinVersion for TLS #5013

merged 1 commit into from
Mar 19, 2020

Conversation

shu-mutou
Copy link
Contributor

Limits TLS <= v1.1 due to security reason.

Closes: #3058

Limits TLS <= v1.1 due to security reason.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 19, 2020
@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #5013 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5013   +/-   ##
=======================================
  Coverage   45.42%   45.42%           
=======================================
  Files         214      214           
  Lines       10066    10066           
  Branches       98       98           
=======================================
  Hits         4572     4572           
  Misses       5226     5226           
  Partials      268      268

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7862472...39a08dd. Read the comment docs.

@floreks
Copy link
Member

floreks commented Mar 19, 2020

I think we can go with that. v1.2 is there for a while, and seem to be supported by most browsers.

https://caniuse.com/#feat=tls1-2

@floreks
Copy link
Member

floreks commented Mar 19, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, shu-mutou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4d047bb into kubernetes:master Mar 19, 2020
@shu-mutou shu-mutou deleted the tls12 branch March 23, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

need a TLS MinVersion arg
3 participants