Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deploying Dashboard on a sub-paths #5022

Merged
merged 1 commit into from Mar 22, 2020

Conversation

floreks
Copy link
Member

@floreks floreks commented Mar 22, 2020

Fixes #5017

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2020
@floreks floreks added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2020
@codecov
Copy link

codecov bot commented Mar 22, 2020

Codecov Report

Merging #5022 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5022      +/-   ##
==========================================
+ Coverage   45.42%   45.42%   +<.01%     
==========================================
  Files         214      214              
  Lines       10066    10078      +12     
  Branches       98      100       +2     
==========================================
+ Hits         4572     4578       +6     
- Misses       5226     5232       +6     
  Partials      268      268
Impacted Files Coverage Δ
...p/frontend/common/services/global/notifications.ts 35.84% <0%> (-2.25%) ⬇️
.../frontend/common/services/global/globalsettings.ts 39.53% <0%> (+0.64%) ⬆️
src/app/backend/settings/handler.go 33.33% <0%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d047bb...67214d3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proxying the dashboard on a sub path broken
2 participants