Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sockjs-go from 2.0.1 to 2.1.0 #5073

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

shu-mutou
Copy link
Contributor

@shu-mutou shu-mutou commented Apr 16, 2020

Latest release v2.0.1 uses CDN that have gone.

Closes #5064

Latest release v2.0.1 uses CDN that have gone.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 16, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2020
@shu-mutou shu-mutou requested review from floreks and maciaszczykm and removed request for konryd and mhenc April 16, 2020 08:02
@maciaszczykm
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2020
@floreks
Copy link
Member

floreks commented Apr 16, 2020

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm, shu-mutou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm,shu-mutou]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #5073 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5073   +/-   ##
=======================================
  Coverage   45.48%   45.48%           
=======================================
  Files         214      214           
  Lines       10073    10073           
  Branches      100      100           
=======================================
  Hits         4582     4582           
  Misses       5225     5225           
  Partials      266      266           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3afe338...3fe64d7. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit 9d78a5f into kubernetes:master Apr 16, 2020
@shu-mutou shu-mutou deleted the bump-sockjs-go branch April 16, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't exec into pod.
4 participants