Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect insecure login #5124

Merged
merged 3 commits into from
May 14, 2020
Merged

Conversation

floreks
Copy link
Member

@floreks floreks commented May 14, 2020

As of now in case an insecure login attempt is detected error will appear and sign-in button will be disabled.

Closes #5103
Closes #5114

In case this behavior will continue after using the new version without seeing the error, those issues can be reopened. I am suspecting that they will see this error now.

Zrzut ekranu z 2020-05-14 14-26-18

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. language/de Updates or issues for German translations. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. labels May 14, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2020
@maciaszczykm
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #5124 into master will decrease coverage by 0.00%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5124      +/-   ##
==========================================
- Coverage   45.48%   45.48%   -0.01%     
==========================================
  Files         214      214              
  Lines       10075    10086      +11     
  Branches      100      103       +3     
==========================================
+ Hits         4583     4588       +5     
- Misses       5226     5231       +5     
- Partials      266      267       +1     
Impacted Files Coverage Δ
.../frontend/common/services/global/authentication.ts 40.90% <50.00%> (+0.58%) ⬆️
src/app/frontend/login/component.ts 81.08% <66.66%> (-0.61%) ⬇️
.../frontend/common/services/global/globalsettings.ts 34.69% <0.00%> (-4.85%) ⬇️
src/app/backend/resource/pod/common.go 58.33% <0.00%> (+1.35%) ⬆️
...p/backend/integration/metric/common/aggregation.go 90.90% <0.00%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09c3770...a914b3b. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit c4a459a into kubernetes:master May 14, 2020
@floreks floreks deleted the feature/login-error branch May 20, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Updates or issues for German translations. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsuccessfull login with keycloak oidc over k8s dashboard Auth behaviors problems
3 participants