-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect insecure login #5124
Detect insecure login #5124
Conversation
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #5124 +/- ##
==========================================
- Coverage 45.48% 45.48% -0.01%
==========================================
Files 214 214
Lines 10075 10086 +11
Branches 100 103 +3
==========================================
+ Hits 4583 4588 +5
- Misses 5226 5231 +5
- Partials 266 267 +1
Continue to review full report at Codecov.
|
As of now in case an insecure login attempt is detected error will appear and sign-in button will be disabled.
Closes #5103
Closes #5114
In case this behavior will continue after using the new version without seeing the error, those issues can be reopened. I am suspecting that they will see this error now.