Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix card expand animation #5161

Merged
merged 1 commit into from
May 21, 2020
Merged

Conversation

floreks
Copy link
Member

@floreks floreks commented May 21, 2020

Fixes #5088

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 21, 2020
@k8s-ci-robot k8s-ci-robot requested review from bryk and mhenc May 21, 2020 11:17
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2020
@maciaszczykm
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #5161 into master will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5161      +/-   ##
==========================================
- Coverage   45.48%   45.48%   -0.01%     
==========================================
  Files         214      214              
  Lines       10086    10089       +3     
  Branches      103      104       +1     
==========================================
+ Hits         4588     4589       +1     
- Misses       5231     5233       +2     
  Partials      267      267              
Impacted Files Coverage Δ
src/app/frontend/common/animations/animations.ts 100.00% <ø> (ø)
...c/app/frontend/common/components/card/component.ts 75.86% <33.33%> (-4.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 153efdf...a2d33f3. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit 50abf41 into kubernetes:master May 21, 2020
@floreks floreks deleted the fix/card-expand branch May 21, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After collapsing view expansion is no longer possible
3 participants