-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aio/Dockerfile): Add nonroot user to final image #5237
Conversation
Welcome @jchauncey! |
Codecov Report
@@ Coverage Diff @@
## master #5237 +/- ##
==========================================
- Coverage 45.45% 45.44% -0.02%
==========================================
Files 214 214
Lines 10099 10097 -2
Branches 108 105 -3
==========================================
- Hits 4591 4589 -2
+ Misses 5241 5239 -2
- Partials 267 269 +2
Continue to review full report at Codecov.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, jchauncey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Vulnerability scans against the dashboard image show that it was created with a nonroot user. Even if the user is changed in the deployment yaml this will still fail the scan.
I have made a similar change for metrics scraper - kubernetes-sigs/dashboard-metrics-scraper#32