Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aio/Dockerfile): Add nonroot user to final image #5237

Merged
merged 1 commit into from
Jun 25, 2020

Conversation

jchauncey
Copy link
Contributor

Vulnerability scans against the dashboard image show that it was created with a nonroot user. Even if the user is changed in the deployment yaml this will still fail the scan.

I have made a similar change for metrics scraper - kubernetes-sigs/dashboard-metrics-scraper#32

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 5, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @jchauncey!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 5, 2020
@k8s-ci-robot k8s-ci-robot requested review from bryk and konryd June 5, 2020 18:13
@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #5237 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5237      +/-   ##
==========================================
- Coverage   45.45%   45.44%   -0.02%     
==========================================
  Files         214      214              
  Lines       10099    10097       -2     
  Branches      108      105       -3     
==========================================
- Hits         4591     4589       -2     
+ Misses       5241     5239       -2     
- Partials      267      269       +2     
Impacted Files Coverage Δ
src/app/backend/resource/pod/common.go 53.26% <0.00%> (-5.08%) ⬇️
src/app/frontend/overview/component.ts 76.92% <0.00%> (-1.65%) ⬇️
src/app/frontend/overview/helper.ts 89.47% <0.00%> (-0.53%) ⬇️
src/app/frontend/login/component.ts 81.94% <0.00%> (-0.25%) ⬇️
src/app/frontend/common/pipes/module.ts 100.00% <0.00%> (ø)
src/app/frontend/common/errors/errors.ts 53.84% <0.00%> (ø)
src/app/frontend/common/pipes/safehtml.ts 42.85% <0.00%> (ø)
src/app/frontend/common/pipes/relativetime.ts 25.58% <0.00%> (ø)
src/app/frontend/common/animations/animations.ts 100.00% <0.00%> (ø)
src/app/frontend/common/resources/groupedlist.ts 50.00% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a289e5...a8eae1f. Read the comment docs.

@floreks
Copy link
Member

floreks commented Jun 25, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, jchauncey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit 946fdc8 into kubernetes:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants