Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move namespace selector #5250

Merged
merged 7 commits into from
Jun 18, 2020
Merged

Move namespace selector #5250

merged 7 commits into from
Jun 18, 2020

Conversation

floreks
Copy link
Member

@floreks floreks commented Jun 10, 2020

As we want to introduce more resources (SA, Roles, etc.) it would cause confusion if we'd add non-namespaced resources under namespace selector or have 2 cluster sections for namespaced and non-namespaced resources. We've decided to move the selector to the top bar and add small indicators to show which sections/resources are namespaced and will be influenced by the namespace change.

Additionally, I have updated Discovery and Load Balancing section to Service as this is how it's called now in the k8s docs.

https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.18/#-strong-service-apis-strong-

This is how it looks like
Peek 2020-06-10 16-48

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/de Updates or issues for German translations. label Jun 10, 2020
@k8s-ci-robot k8s-ci-robot added language/fr Updates or issues for French translations. approved Indicates a PR has been approved by an approver from all required OWNERS files. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. labels Jun 10, 2020
@maciaszczykm
Copy link
Member

What do you think about removing the separator before "Custom Resource Definitions"?

@floreks
Copy link
Member Author

floreks commented Jun 12, 2020

Depends, to which section it belongs in K8S API docs?

@maciaszczykm
Copy link
Member

To the cluster section. However, for us it should be a section on its own as we are displaying the pinned CRDs below.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 18, 2020
@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #5250 into master will decrease coverage by 0.11%.
The diff coverage is 33.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5250      +/-   ##
==========================================
- Coverage   45.53%   45.42%   -0.12%     
==========================================
  Files         214      214              
  Lines       10117    10208      +91     
  Branches      107      108       +1     
==========================================
+ Hits         4607     4637      +30     
- Misses       5239     5298      +59     
- Partials      271      273       +2     
Impacted Files Coverage Δ
src/app/backend/api/types.go 35.29% <ø> (ø)
...c/app/frontend/common/services/global/actionbar.ts 45.45% <0.00%> (-4.55%) ⬇️
src/app/backend/handler/apihandler.go 27.74% <28.57%> (+0.03%) ⬆️
src/app/backend/handler/filter.go 45.45% <46.15%> (ø)
src/app/backend/resource/secret/list.go 37.20% <50.00%> (ø)
...rontend/common/components/resourcelist/groupids.ts 100.00% <100.00%> (ø)
.../app/frontend/common/services/resource/endpoint.ts 80.35% <100.00%> (+0.72%) ⬆️
src/app/backend/sync/secret.go 70.29% <0.00%> (-2.98%) ⬇️
...p/backend/integration/metric/common/aggregation.go 89.09% <0.00%> (-1.82%) ⬇️
src/app/frontend/common/pipes/relativetime.ts 25.58% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 171bf10...c47ef8c. Read the comment docs.

@floreks floreks merged commit f3ca4ac into kubernetes:master Jun 18, 2020
@floreks floreks deleted the refactor/sidebar branch June 18, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Updates or issues for German translations. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants