Dump angular 11 #5745

damingerdai · 2021-01-05T10:59:29Z

No description provided.

k8s-ci-robot · 2021-01-05T10:59:35Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2021-01-05T10:59:37Z

Welcome @damingerdai!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

damingerdai · 2021-01-05T11:01:29Z

may i make some mistakes.

codecov · 2021-01-05T11:07:27Z

Codecov Report

Merging #5745 (fd0065e) into master (5cf991c) will increase coverage by 0.09%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master    #5745      +/-   ##
==========================================
+ Coverage   44.37%   44.47%   +0.09%     
==========================================
  Files         214      214              
  Lines        9117     9120       +3     
  Branches      112      110       -2     
==========================================
+ Hits         4046     4056      +10     
+ Misses       4796     4790       -6     
+ Partials      275      274       -1

maciaszczykm · 2021-01-05T11:07:28Z

src/app/frontend/common/pipes/coreformatter.ts

@@ -23,6 +23,7 @@ export class CoreFormatter extends DecimalPipe {
  readonly base = 1000;
  readonly powerSuffixes = ['m', '', 'k', 'M', 'G', 'T'];

+  // @ts-ignore


Can you explain this?

it looks like a typescript compiler error

Error: src/app/frontend/common/pipes/coreformatter.ts:26:3 - error TS2416: Property 'transform' in type 'CoreFormatter' is not assignable to the same property in base type 'DecimalPipe'. Type '(value: number) => string' is not assignable to type '{ (value: string | number, digitsInfo?: string, locale?: string): string; (value: null, digitsInfo?: string, locale?: string): null; (value: string | number, digitsInfo?: string, locale?: string): string; }'. Type 'string' is not assignable to type 'null'. 26 transform(value: number): string { ~~~~~~~~~ src/app/frontend/common/pipes/memoryformatter.ts:26:3 - error TS2416: Property 'transform' in type 'MemoryFormatter' is not assignable to the same property in base type 'DecimalPipe'. Type '(value: number) => string' is not assignable to type '{ (value: string | number, digitsInfo?: string, locale?: string): string; (value: null, digitsInfo?: string, locale?: string): null; (value: string | number, digitsInfo?: string, locale?: string): string; }'. Type 'string' is not assignable to type 'null'. 26 transform(value: number): string { ~~~~~~~~~

with @ts-ignore, the tsc command will ignore this error

It has to be fixed then, not ignored

must we fix it in this pr?

100%, I prefer to keep Angular 10 without any hidden issues than go to the 11 but with workarounds and ignored errors.

Have you tested if the pipes works with the introduced annotations and there are no errors in the console?

I finally understand why it happened by this angular issue
these are some breaking changes in angular about pipes.
So if we want to upgrade angular 11, we have to fix these error.

damingerdai · 2021-01-05T13:59:37Z

I signed it

damingerdai · 2021-01-05T14:29:18Z

I signed it

damingerdai · 2021-01-05T14:32:36Z

I signed it.

damingerdai · 2021-01-05T14:33:20Z

i have finished cla!!!

damingerdai · 2021-01-06T02:59:12Z

@maciaszczykm please review again

maciaszczykm · 2021-01-07T09:35:27Z

Testing it.

…0-beta.33

maciaszczykm · 2021-01-07T10:38:09Z

/lgtm
/approve

k8s-ci-robot · 2021-01-07T10:38:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damingerdai, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 5, 2021

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 5, 2021

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 5, 2021

k8s-ci-robot requested review from maciaszczykm and shu-mutou January 5, 2021 10:59

damingerdai changed the title ~~build(deps): dump angular 11~~ Dump angular 11 Jan 5, 2021

maciaszczykm reviewed Jan 5, 2021

View reviewed changes

damingerdai force-pushed the ng11 branch 2 times, most recently from 040ce8f to 2628912 Compare January 5, 2021 13:36

damingerdai requested a review from maciaszczykm January 5, 2021 13:54

damingerdai force-pushed the ng11 branch from 2628912 to 73216cd Compare January 5, 2021 13:56

k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 5, 2021

damingerdai force-pushed the ng11 branch from 73216cd to 714845f Compare January 5, 2021 14:17

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 5, 2021

damingerdai requested a review from floreks January 5, 2021 14:34

damingerdai force-pushed the ng11 branch from 714845f to 1574bcb Compare January 6, 2021 02:57

damingerdai force-pushed the ng11 branch from 1574bcb to e9ad92c Compare January 6, 2021 03:01

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 7, 2021

build(deps): upgrade angular from 10.1.6 to 11.0.5

a65ad54

damingerdai and others added 5 commits January 7, 2021 11:01

build(deps-dev): upgrade angular cli from 10.1.7 to 11.0.5

d7f7a95

build(deps): upgrade angular material/cdk from 10.2.5 to 11.0.3

f2f6be9

build(deps): upgrade angular flex-layout from 10.0.0-beta.32 to 11.0.…

44bc670

…0-beta.33

fix: reactor transform method for CoreFormatter and MemoryFormatter

2f9c270

Update dependencies, fix deprecation warnings, optimize pipes

fd0065e

floreks force-pushed the ng11 branch from 7b6b854 to fd0065e Compare January 7, 2021 10:01

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 7, 2021

k8s-ci-robot assigned maciaszczykm Jan 7, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2021

k8s-ci-robot merged commit cd12362 into kubernetes:master Jan 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dump angular 11 #5745

Dump angular 11 #5745

damingerdai commented Jan 5, 2021

k8s-ci-robot commented Jan 5, 2021

k8s-ci-robot commented Jan 5, 2021

damingerdai commented Jan 5, 2021

codecov bot commented Jan 5, 2021 •

edited

Loading

maciaszczykm Jan 5, 2021

damingerdai Jan 5, 2021

damingerdai Jan 5, 2021

floreks Jan 5, 2021

damingerdai Jan 5, 2021

maciaszczykm Jan 5, 2021

maciaszczykm Jan 5, 2021

damingerdai Jan 5, 2021

damingerdai commented Jan 5, 2021

damingerdai commented Jan 5, 2021

damingerdai commented Jan 5, 2021

damingerdai commented Jan 5, 2021

damingerdai commented Jan 6, 2021

maciaszczykm commented Jan 7, 2021

maciaszczykm commented Jan 7, 2021

k8s-ci-robot commented Jan 7, 2021

Dump angular 11 #5745

Dump angular 11 #5745

Conversation

damingerdai commented Jan 5, 2021

k8s-ci-robot commented Jan 5, 2021

k8s-ci-robot commented Jan 5, 2021

damingerdai commented Jan 5, 2021

codecov bot commented Jan 5, 2021 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

damingerdai commented Jan 5, 2021

damingerdai commented Jan 5, 2021

damingerdai commented Jan 5, 2021

damingerdai commented Jan 5, 2021

damingerdai commented Jan 6, 2021

maciaszczykm commented Jan 7, 2021

maciaszczykm commented Jan 7, 2021

k8s-ci-robot commented Jan 7, 2021

codecov bot commented Jan 5, 2021 •

edited

Loading