Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve deep-links after logging in #5777

Merged
merged 1 commit into from Jan 28, 2021

Conversation

floreks
Copy link
Member

@floreks floreks commented Jan 28, 2021

Fixes #5340

Peek 2021-01-28 12-17

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 28, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2021
@maciaszczykm
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #5777 (996fffc) into master (1aec8a2) will decrease coverage by 0.58%.
The diff coverage is 27.27%.

@@            Coverage Diff             @@
##           master    #5777      +/-   ##
==========================================
- Coverage   44.43%   43.85%   -0.59%     
==========================================
  Files         214      215       +1     
  Lines        9127     9148      +21     
  Branches      110      112       +2     
==========================================
- Hits         4056     4012      -44     
- Misses       4797     4870      +73     
+ Partials      274      266       -8     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preserve deep-links thru login
3 participants