Pod security context2

[marcosdiez]

It turns out both pods and containers can have their own security context.
To make things worse, although the container one has priority, they only share a few of the properties.

I actually spent some time thinking about how to make the UI less confusing, despite the reality.

This is what I came up with:

On the code level, I did something that is either very smart or very dumb depending on the point of view:

The backend just exposes the info. So nothing special here.

On the frontend, we now have 3 similar objects:

• PodSecurityContext (for pods)
• ContainerSecurityContext (for containers)
• PodContainerMergedSecurityContext (artificial structure which is a merge of the two above, with all fields optional, so we can use the same UI to widget both, since they are very similar)

So although the Pod does expose PodSecurityContext and the container does expose ContainerSecurityContext, the security context list interprete it as PodContainerMergedSecurityContext and plots its accordinly.

As always, @floreks , please be the judge.

By the way I never explicitly had the chance to thank you for thoughtfully reviewing every single PR of mine and even going to the extra work of rewriting them when needed. Thank you. Really!

Here is a minimalist example of a yaml to test this:

kind: Pod
apiVersion: v1
metadata:
  name: test-security-context2
  namespace: default
spec:
  containers:
    - name: test-security-context2
      image: alpine:latest
      command:
        - tail
        - '-f'
        - /dev/null
      securityContext:
        readOnlyRootFilesystem: true
  securityContext:
    runAsGroup: 1000
    runAsUser: 1000

[codecov]

Codecov Report

Merging #5794 (b190348) into master (aeba15d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5794      +/-   ##
==========================================
+ Coverage   43.80%   43.82%   +0.01%     
==========================================
  Files         215      215              
  Lines        9166     9167       +1     
  Branches      112      112              
==========================================
+ Hits         4015     4017       +2     
+ Misses       4885     4884       -1     
  Partials      266      266              

[floreks]

Refactored code/ui a bit and moved pod security context to the resource information to be consistent.

[floreks]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, marcosdiez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floreks]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment