Hosts are now shown in the ingress list #5800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marcosdiez
commented
Feb 10, 2021
•
marcosdiez
commented
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
language/fr
marcosdiez
force-pushed
the
hosts_in_ingress_list
branch
from
f893b6c
to
550d4ca
Compare
Codecov Report
@@ Coverage Diff @@
## master #5800 +/- ##
=======================================
Coverage 43.82% 43.82%
=======================================
Files 215 215
Lines 9167 9167
Branches 112 112
=======================================
Hits 4017 4017
Misses 4884 4884
Partials 266 266 |
marcosdiez
force-pushed
the
hosts_in_ingress_list
branch
from
550d4ca
to
76a0fc0
Compare
marcosdiez
changed the title
floreks
reviewed
Feb 11, 2021
k8s-ci-robot
added
the
needs-rebase
floreks
reviewed
Feb 11, 2021
k8s-ci-robot
removed
the
needs-rebase
|
/lgtm |
floreks
added
the
approved
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, marcosdiez The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.