Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide pagination controls if there is only one page #5827

Merged
merged 2 commits into from
Feb 25, 2021
Merged

Hide pagination controls if there is only one page #5827

merged 2 commits into from
Feb 25, 2021

Conversation

maciaszczykm
Copy link
Member

Closes #5747.

Marcin Maciaszczyk added 2 commits February 25, 2021 13:23
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 25, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 25, 2021
@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #5827 (a5c1362) into master (6c8dea1) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5827      +/-   ##
==========================================
- Coverage   43.84%   43.83%   -0.02%     
==========================================
  Files         215      215              
  Lines        9174     9174              
  Branches      113      113              
==========================================
- Hits         4022     4021       -1     
- Misses       4886     4887       +1     
  Partials      266      266

@jeefy
Copy link
Member

jeefy commented Feb 25, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeefy, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 520a89d into kubernetes:master Feb 25, 2021
@maciaszczykm maciaszczykm deleted the feature/hide-paginator branch February 25, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floreks floreks Awaiting requested review from floreks

@jeefy jeefy Awaiting requested review from jeefy

Assignees

@jeefy jeefy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide pagination controls if there is only one page
3 participants
@maciaszczykm @jeefy @k8s-ci-robot