Pod HealthCheck

[marcosdiez]

Floresk, please feel free to change the layout as you prefer!

Also, I need CSS help removing whitespaces on the HTTP Healthcheck URI

ps: an excellent container to test this is kube-system/coredns

[floreks]

To be honest I wouldn't want to add so many details to the pod info. There is already a lot of information there and the liveness probe can be easily checked by simply clicking edit and looking at yaml.

[marcosdiez]

I understand, but if some users can't read YAML ...
Separating the container from the POD is also not a good idea because they have too much info in common.

What if we get a compromise. Like the healthcheck comes "closed" or "minimized" by default and one needs to click on it to open it ?

Also, to make life worse, sooner or later I might provide you a patch to see the TCP ports of the containers.

My users need that :/

[floreks]

We have to rethink how to better manage information display as the pod page tends to get quite long already. We can merge for now but soon we'll have to improve it.

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, marcosdiez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floreks]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Merging #6145 (8116bbc) into master (c1883cd) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #6145      +/-   ##
==========================================
- Coverage   41.48%   41.47%   -0.02%     
==========================================
  Files         216      216              
  Lines        9347     9350       +3     
  Branches      159      159              
==========================================
  Hits         3878     3878              
- Misses       5217     5220       +3     
  Partials      252      252              

[marcosdiez]

Very smart from your side! And I was fighting for hours with CSS. Thank you once more!