PersistentVolumeClaim details pane now shows a link to it's PersistVolume (if any)

[marcosdiez]

[codecov]

Codecov Report

Merging #6169 (27de9fd) into master (325399e) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6169      +/-   ##
==========================================
+ Coverage   41.42%   41.46%   +0.04%     
==========================================
  Files         216      216              
  Lines        9352     9352              
  Branches      144      144              
==========================================
+ Hits         3874     3878       +4     
+ Misses       5228     5223       -5     
- Partials      250      251       +1     

[maciaszczykm]

LGTM but there is a conflict.

[marcosdiez]

Hello @maciaszczykm ! The conflict is gone (it was only translations)

[marcosdiez]

my bad. now it's really fixed.

[marcosdiez]

Hey, @maciaszczykm
I was thinking, most of my commits is me fighting with i18n stuff (that are unrelated to my code)
that also makes the code review much harder (because the i18n stuff is only noise for code review)
and it also makes impossible to merge two UI related PRs at once.

Does it still make sense for us to include i18n stuff in our feature PRs ?

[maciaszczykm]

Yes, the process is a bit broken right now but it has to be done regularly.

[jeefy]

@marcosdiez Looks like e2e tests are failing :( Can you address?

[marcosdiez]

Hello @jeefy
This is a problem in the test, not in my code.
The proof for it is that my last real commit (with code, not i18n stuff) worked:

So if you really want, I can keep sending empty commit. Eventually all tests will pass. But there is nothing for me to do on my side...

[maciaszczykm]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm, marcosdiez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment