Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly decode base64 encoded UTF-8 strings #6236

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

floreks
Copy link
Member

@floreks floreks commented Jul 7, 2021

Fixes #6233

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 7, 2021
@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #6236 (92b8cd3) into master (e482f07) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6236   +/-   ##
=======================================
  Coverage   41.46%   41.46%           
=======================================
  Files         216      216           
  Lines        9352     9352           
  Branches      160      160           
=======================================
  Hits         3878     3878           
  Misses       5222     5222           
  Partials      252      252           

@floreks floreks merged commit 3c7ec07 into kubernetes:master Jul 7, 2021
@floreks floreks deleted the fix/decode branch July 7, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

secret decode - Using JavaScript's atob decoder Base64 can't decode UTF-8 strings correctly
2 participants