Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed indentation of annotations. #6837

Merged
merged 2 commits into from Feb 22, 2022
Merged

Fixed indentation of annotations. #6837

merged 2 commits into from Feb 22, 2022

Conversation

ghost
Copy link

@ghost ghost commented Feb 21, 2022

From #6750
Since it was added in #6676, it has been failing.

Since it was added in #6676, it has been failing.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 21, 2022
@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #6837 (37c26dc) into master (cb6355b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6837   +/-   ##
=======================================
  Coverage   41.61%   41.61%           
=======================================
  Files          44       44           
  Lines        1228     1228           
  Branches      162      162           
=======================================
  Hits          511      511           
  Misses        717      717           

@shu-mutou
Copy link
Contributor

/lgtm
Nice catch!! Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fukuta-tatsuya-intec, shu-mutou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit 71c8503 into kubernetes:master Feb 22, 2022
@desaintmartin
Copy link
Member

In fact it was the other side: de-indent! ;)

I've created #6839 to add testing (and finally fix).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants