Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license check #7518

Merged
merged 5 commits into from
Nov 14, 2022
Merged

Fix license check #7518

merged 5 commits into from
Nov 14, 2022

Conversation

maciaszczykm
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 4, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2022
@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #7518 (dcb65fe) into master (95e7e84) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7518   +/-   ##
=======================================
  Coverage   42.09%   42.10%           
=======================================
  Files         217      217           
  Lines       12084    12084           
  Branches      179      179           
=======================================
+ Hits         5087     5088    +1     
+ Misses       6712     6711    -1     
  Partials      285      285           

@maciaszczykm
Copy link
Member Author

@desaintmartin Do you know why Helm linting fails here?

@maciaszczykm
Copy link
Member Author

I'd like to merge it ASAP as other PRs have failing license checks.

@desaintmartin
Copy link
Member

Let me check this.

@floreks
Copy link
Member

floreks commented Nov 14, 2022

Outdated API usage.

Error: INSTALLATION FAILED: unable to build kubernetes objects from release manifest: resource mapping not found for name: "kubernetes-dashboard-9x8a59zw5e" namespace: "" from "": no matches for kind "PodDisruptionBudget" in version "policy/v1beta1"

@desaintmartin
Copy link
Member

Fixed in #7530

Signed-off-by: Marcin Maciaszczyk <marcin9yk@icloud.com>
@maciaszczykm
Copy link
Member Author

@desaintmartin Thank you!

@maciaszczykm maciaszczykm merged commit 6b3d97f into kubernetes:master Nov 14, 2022
@maciaszczykm maciaszczykm deleted the license branch November 14, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants