Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added helm chart optional containers #7554

Merged

Conversation

daiyyr
Copy link
Contributor

@daiyyr daiyyr commented Dec 8, 2022

Give an option for those who need auth add-ons such as keycloak

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 8, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: daiyyr / name: Teemo (90203af)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 8, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @daiyyr!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 8, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 8, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 9, 2022
@daiyyr
Copy link
Contributor Author

daiyyr commented Dec 19, 2022

Hi @maciaszczykm, comments resolved, can you please have a look again. Thank you!

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #7554 (17f23ad) into master (437d055) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7554   +/-   ##
=======================================
  Coverage   42.09%   42.09%           
=======================================
  Files         217      217           
  Lines       12084    12084           
  Branches      179      179           
=======================================
  Hits         5087     5087           
  Misses       6712     6712           
  Partials      285      285           

@maciaszczykm
Copy link
Member

You didn't update the version.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 21, 2022
@daiyyr
Copy link
Contributor Author

daiyyr commented Dec 21, 2022

You didn't update the version.

Sorry misunderstood - was checking to rebase any dependency update but found none. Bumped the version to 6.0.3.

Signed-off-by: Marcin Maciaszczyk <marcin9yk@icloud.com>
@maciaszczykm
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 22, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2022
@daiyyr
Copy link
Contributor Author

daiyyr commented Dec 22, 2022

Fixed linting error. Please tag with lgtm again

@daiyyr
Copy link
Contributor Author

daiyyr commented Jan 9, 2023

Happy new year! When you come back from holidays, can you please review the change trying fix the linting error

@maciaszczykm
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daiyyr, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 46677ca into kubernetes:master Jan 10, 2023
@daiyyr daiyyr deleted the helm-chart-add-optional-containers branch January 10, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants