Enable make serve on development container
#7631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Codecov Report
@@ Coverage Diff @@
## master #7631 +/- ##
==========================================
- Coverage 42.19% 42.18% -0.01%
==========================================
Files 218 218
Lines 12099 12099
Branches 180 180
==========================================
- Hits 5105 5104 -1
- Misses 6709 6710 +1
Partials 285 285 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Also, shorten env names.
shu-mutou
force-pushed
the
dev-container
branch
from
615eb4a
to
1bb2549
Compare
k8s-ci-robot
removed
the
lgtm
|
rebased to skip e2e test. |
|
@maciaszczykm PTAL. Thanks! |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maciaszczykm, shu-mutou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, clean up envs for development container.