Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh] Change i18n text in messages.xlf #7654

Merged
merged 1 commit into from
Mar 18, 2023
Merged

[zh] Change i18n text in messages.xlf #7654

merged 1 commit into from
Mar 18, 2023

Conversation

windsonsea
Copy link
Member

@windsonsea windsonsea commented Mar 9, 2023 •
edited

Changed for:

  • consistency
  • typos correction
  • checked lines with state="new"

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 9, 2023
@k8s-ci-robot k8s-ci-robot added the language/zh Updates or issues for Chinese translations. label Mar 9, 2023
@codecov
Copy link

codecov bot commented Mar 9, 2023 •
edited

Codecov Report

Merging #7654 (d574f4c) into master (ac08146) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7654      +/-   ##
==========================================
- Coverage   42.16%   42.13%   -0.04%     
==========================================
  Files         217      217              
  Lines       12092    12092              
  Branches      179      179              
==========================================
- Hits         5099     5095       -4     
- Misses       6708     6713       +5     
+ Partials      285      284       -1

hwdef
hwdef reviewed Mar 17, 2023
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not receiving the notification, if you submit pr again in the future, please at me

modules/web/i18n/zh-Hans/messages.zh-Hans.xlf Outdated
@@ -340,15 +340,15 @@
</trans-unit>
<trans-unit id="2027381191177847167" datatype="html">
<source>Exec Commands</source>
<target state="new">Exec Commands</target>
<target state="new">执行命令</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<target state="new">执行命令</target>
<target>执行命令</target>

Please remove state="new" for translated places.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I need to remove all state="new" in this file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the line has already been translated and does not require modification,please remove the state="new",If you have enough time, you can do some cleanup for this file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well received. Have checked all lines with status="new"

modules/web/i18n/zh-Hans/messages.zh-Hans.xlf Outdated Show resolved Hide resolved
modules/web/i18n/zh-Hans/messages.zh-Hans.xlf Outdated Show resolved Hide resolved
modules/web/i18n/zh-Hans/messages.zh-Hans.xlf Outdated Show resolved Hide resolved
modules/web/i18n/zh-Hans/messages.zh-Hans.xlf Outdated Show resolved Hide resolved
modules/web/i18n/zh-Hans/messages.zh-Hans.xlf Outdated Show resolved Hide resolved
@windsonsea windsonsea force-pushed the messagey branch 2 times, most recently from 25929d3 to e34791a Compare March 17, 2023 10:29
@windsonsea
[zh] Change some text in messages.xlf
d574f4c 
Signed-off-by: windsonsea <haifeng.yao@daocloud.io>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 18, 2023
@windsonsea windsonsea changed the title [zh] Change some text in messages.xlf [zh] Change i18n text in messages.xlf Mar 18, 2023
hwdef
hwdef reviewed Mar 18, 2023
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution to this project!
In addition, I have two suggestions:

  1. Compile and deploy after the modification, and check that the modification is correct.
  2. Proper nouns remain as they are

@hwdef
Copy link
Member

hwdef commented Mar 18, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hwdef, windsonsea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit 74c5145 into kubernetes:master Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwdef hwdef hwdef left review comments

@chenrui333 chenrui333 Awaiting requested review from chenrui333

@zehuaiWANG zehuaiWANG Awaiting requested review from zehuaiWANG

@helight helight Awaiting requested review from helight

@tanjunchen tanjunchen Awaiting requested review from tanjunchen

Assignees

@hwdef hwdef

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Updates or issues for Chinese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@windsonsea @hwdef @k8s-ci-robot