Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump metrics-server dependency in helm chart to 3.8.4 #7702

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

laurence-hudson-mindfoundry
Copy link
Contributor

Bump metrics-server dependency in helm chart from 3.8.3 to 3.8.4 to account for migration of k8s.gcr.io to registry.k8s.io.

Migration of image registry is the only listed change in the changelog for metric server's 3.8.4 chart.

https://kubernetes.io/blog/2023/02/06/k8s-gcr-io-freeze-announcement/

…ccount for migration of k8s.gcr.io to registry.k8s.io
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 13, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: laurence-hudson-mindfoundry / name: Laurence Hudson (0bb22a1)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 13, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @laurence-hudson-mindfoundry!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 13, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 13, 2023
@maciaszczykm
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 14, 2023
@maciaszczykm
Copy link
Member

@laurence-hudson-mindfoundry You need to bump chart version.

Signed-off-by: Marcin Maciaszczyk <marcin9yk@icloud.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 14, 2023
@maciaszczykm
Copy link
Member

maciaszczykm commented Apr 14, 2023

Never mind, done it on my own.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: laurence-hudson-mindfoundry, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #7702 (e8d9a62) into master (61c1a52) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7702   +/-   ##
=======================================
  Coverage   42.19%   42.19%           
=======================================
  Files         218      218           
  Lines       12099    12099           
  Branches      180      180           
=======================================
  Hits         5105     5105           
  Misses       6709     6709           
  Partials      285      285           

@laurence-hudson-mindfoundry
Copy link
Contributor Author

Ah, of course. Thanks

@k8s-ci-robot k8s-ci-robot merged commit 0179722 into kubernetes:master Apr 14, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants