Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional controls for pod admission restricted #7722

Merged
merged 1 commit into from
May 19, 2023

Conversation

jcpunk
Copy link
Contributor

@jcpunk jcpunk commented May 2, 2023

This adds some additional default settings to the dashboard helm chart for pod-security restricted.

End users of the chart shouldn't notice anything different as the disabled features are not used by the application.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 2, 2023
Signed-off-by: Pat Riehecky <riehecky@fnal.gov>
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #7722 (52c7554) into master (215d1b3) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7722      +/-   ##
==========================================
+ Coverage   42.16%   42.18%   +0.02%     
==========================================
  Files         218      218              
  Lines       12099    12099              
  Branches      179      179              
==========================================
+ Hits         5101     5104       +3     
+ Misses       6714     6710       -4     
- Partials      284      285       +1     

Copy link
Member

@desaintmartin desaintmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign
/lgtm
Thanks for the contribution!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: desaintmartin, jcpunk, r0b2g1t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit dfd20b4 into kubernetes:master May 19, 2023
14 checks passed
@jcpunk jcpunk deleted the pod-security-restricted branch May 19, 2023 13:52
@jcpunk
Copy link
Contributor Author

jcpunk commented May 19, 2023

The CI seems to be failing...

@desaintmartin
Copy link
Member

The helm CD part worked and produced #7747 which should be merged soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants