-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Prometheus labels #7749
Conversation
# Conflicts: # charts/helm-chart/kubernetes-dashboard/Chart.yaml
/assign @desaintmartin |
@maciaszczykm could you trigger CI pipeline? |
Codecov Report
@@ Coverage Diff @@
## master #7749 +/- ##
==========================================
+ Coverage 42.01% 42.19% +0.17%
==========================================
Files 163 218 +55
Lines 10827 12099 +1272
Branches 0 179 +179
==========================================
+ Hits 4549 5105 +556
- Misses 6031 6709 +678
- Partials 247 285 +38 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It works this time!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ColdFire87, desaintmartin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks everyone 👍 |
Hi,
This PR adds labeling support for ServiceMonitor endpoints. Those labels end up on the jobs/targets, and can be used to group jobs. E.g. can add a
department
&team
label:This can then be used in Grafana dashboards to group jobs by labels (or add variables to filter):
EDIT: This is the same PR as #7720, but I had to sync the changes into my fork, which forced the closure of the previous PR.