Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dashboard Tour href to point to Dashboard Docs instead of nothing #7750

Merged
merged 1 commit into from
May 23, 2023

Conversation

mdbudnick
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 22, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @mdbudnick!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 22, 2023
@mdbudnick
Copy link
Contributor Author

/test all

@k8s-ci-robot
Copy link
Contributor

@mdbudnick: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mdbudnick
Copy link
Contributor Author

/honk

@k8s-ci-robot
Copy link
Contributor

@mdbudnick:
goose image

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mdbudnick
Copy link
Contributor Author

/status in-review

@mdbudnick
Copy link
Contributor Author

/pony Moonbeam

@k8s-ci-robot
Copy link
Contributor

@mdbudnick: Couldn't find a pony matching given tag(s).

In response to this:

/pony Moonbeam

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mdbudnick
Copy link
Contributor Author

/pony

@k8s-ci-robot
Copy link
Contributor

@mdbudnick: pony image

In response to this:

/pony

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mdbudnick
Copy link
Contributor Author

/trickortreat

@k8s-ci-robot
Copy link
Contributor

@mdbudnick: candy image

In response to this:

/trickortreat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mdbudnick
Copy link
Contributor Author

/joke

@k8s-ci-robot
Copy link
Contributor

@mdbudnick: Why was the shirt happy to hang around the tank top? Because it was armless

In response to this:

/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@maciaszczykm maciaszczykm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm, mdbudnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2023
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #7750 (b16bd01) into master (ac5da43) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7750      +/-   ##
==========================================
- Coverage   42.18%   42.16%   -0.03%     
==========================================
  Files         218      218              
  Lines       12099    12099              
  Branches      179      179              
==========================================
- Hits         5104     5101       -3     
- Misses       6710     6714       +4     
+ Partials      285      284       -1     

@k8s-ci-robot k8s-ci-robot merged commit 0d12436 into kubernetes:master May 23, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants