Prevent to run postinstall for yarn during dependabot check #7757
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
size/S
Codecov Report
@@ Coverage Diff @@
## master #7757 +/- ##
==========================================
- Coverage 42.18% 42.16% -0.02%
==========================================
Files 218 218
Lines 12099 12099
Branches 179 179
==========================================
- Hits 5104 5102 -2
- Misses 6710 6713 +3
+ Partials 285 284 -1 |
|
This PR needs to be merged and run the dependabot check to see the result, so this may need to be reverted later. |
|
/retitle Prevent to run postinstall for yarn during dependabot check |
k8s-ci-robot
changed the title
postinstall for yarn during dependabot check
|
@floreks @maciaszczykm Can we try this once? |
modules/web/hack/postinstall.sh
Outdated
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| if [ -z "$(env | grep DEPENDABOT_HOME)" ]; then |
There was a problem hiding this comment.
Instead of using "$(env | grep DEPENDABOT_HOME)" you can just use "$DEPENDABOT_HOME".
There was a problem hiding this comment.
Thank you for reviewing. I left what I was trying in my .yarnrc.yml... 😳
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maciaszczykm, shu-mutou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This seems to work well!! |
Investigate workaround to run dependabot for js/ts.
dependabot fails to execute postinstall when checking js/ts dependencies. I don't think dependabot needs postinstall, so I'll try not to run postinstall on dependabot.