Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): role/clusterole/podlist endpoints #8881

Merged
merged 6 commits into from Apr 5, 2024
Merged

fix(api): role/clusterole/podlist endpoints #8881

merged 6 commits into from Apr 5, 2024

Conversation

floreks
Copy link
Member

@floreks floreks commented Apr 5, 2024

  • fix role/clusterole list from all namespaces endpoint
  • improve logging when metrics are disabled
  • add container status list to pod list

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 5, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 5, 2024
@floreks floreks added the kind/bug Categorizes issue or PR as related to a bug. label Apr 5, 2024
@floreks floreks self-assigned this Apr 5, 2024
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Merging #8881 (7bf45ae) into master (16df35e) will increase coverage by 0.12%.
Report is 1 commits behind head on master.
The diff coverage is 72.72%.

❗ Current head 7bf45ae differs from pull request most recent head 64fed56. Consider uploading reports for the commit 64fed56 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8881      +/-   ##
==========================================
+ Coverage   37.50%   37.63%   +0.12%     
==========================================
  Files         255      256       +1     
  Lines       11155    11186      +31     
  Branches      157      158       +1     
==========================================
+ Hits         4184     4210      +26     
- Misses       6720     6763      +43     
+ Partials      251      213      -38     

@maciaszczykm
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@floreks floreks added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2024
@floreks floreks merged commit cb65bda into master Apr 5, 2024
15 of 16 checks passed
@floreks floreks deleted the fix/api branch April 5, 2024 11:31
kireque pushed a commit to kireque/home-ops that referenced this pull request Apr 6, 2024
…430)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [kubernetes-dashboard](https://togithub.com/kubernetes/dashboard) |
minor | `7.1.3` -> `7.2.0` |

---

### Release Notes

<details>
<summary>kubernetes/dashboard (kubernetes-dashboard)</summary>

###
[`v7.2.0`](https://togithub.com/kubernetes/dashboard/releases/tag/kubernetes-dashboard-7.2.0)

[Compare
Source](https://togithub.com/kubernetes/dashboard/compare/kubernetes-dashboard-7.1.3...kubernetes-dashboard-7.2.0)

#### What's Changed

- ci: Fix CodeQL check and ignore codecov token error by
[@&#8203;shu-mutou](https://togithub.com/shu-mutou) in
[kubernetes/dashboard#8827
- chore(deps-dev): bump cypress from 13.6.6 to 13.7.1 in /modules/web by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8825
- chore(deps): bump docker/login-action from 3.0.0 to 3.1.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8786
- chore(deps-dev): bump sass from 1.71.1 to 1.72.0 in /modules/web by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8789
- chore(deps-dev): bump webpack-dev-server from 5.0.2 to 5.0.4 in
/modules/web by [@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8817
- chore(deps): bump docker/setup-buildx-action from 3.1.0 to 3.2.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8797
- chore(deps): bump follow-redirects from 1.15.5 to 1.15.6 in
/modules/web by [@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8803
- chore(deps): bump webpack-dev-middleware from 5.3.3 to 5.3.4 in
/modules/web by [@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8824
- chore(deps-dev): bump
[@&#8203;graphql-mesh/openapi](https://togithub.com/graphql-mesh/openapi)
from 0.99.2 to 0.99.6 in /modules/web by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8831
- chore(deps): bump codecov/codecov-action from 4.1.0 to 4.1.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8839
- chore(deps-dev): bump
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)
from 7.1.1 to 7.5.0 in /modules/web by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8850
- chore(deps-dev): bump minimatch from 9.0.3 to 9.0.4 in /modules/web by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8852
- chore(deps): bump github.com/prometheus/client_golang from 1.18.0 to
1.19.0 in /modules/api by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8727
- chore(deps): bump azure/setup-helm from 4.0.0 to 4.1.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8751
- chore(deps): bump google.golang.org/protobuf from 1.31.0 to 1.33.0 in
/modules/common/tools by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8781
- chore(deps): bump google.golang.org/protobuf from 1.31.0 to 1.33.0 in
/modules/metrics-scraper by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8782
- chore(deps): bump google.golang.org/protobuf from 1.31.0 to 1.33.0 in
/modules/auth by [@&#8203;dependabot](https://togithub.com/dependabot)
in
[kubernetes/dashboard#8783
- chore(deps): bump google.golang.org/protobuf from 1.31.0 to 1.33.0 in
/modules/web by [@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8785
- chore(deps-dev): bump
[@&#8203;graphql-mesh/cli](https://togithub.com/graphql-mesh/cli) from
0.89.0 to 0.89.8 in /modules/web by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8849
- chore(deps): bump google.golang.org/protobuf from 1.31.0 to 1.33.0 in
/modules/api by [@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8780
- chore(deps): bump github.com/emicklei/go-restful/v3 from 3.11.3 to
3.12.0 in /modules/api by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8773
- chore(deps): bump express from 4.18.3 to 4.19.2 in /modules/web by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8845
- chore(deps-dev): bump
[@&#8203;graphql-mesh/runtime](https://togithub.com/graphql-mesh/runtime)
from 0.98.0 to 0.98.7 in /modules/web by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8847
- chore(deps-dev): bump
[@&#8203;types/node](https://togithub.com/types/node) from 20.11.24 to
20.12.2 in /modules/web by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8848
- chore(deps): bump github.com/golangci/golangci-lint from 1.56.2 to
1.57.2 in /modules/common/tools by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8844
- chore(deps): bump google.golang.org/protobuf from 1.31.0 to 1.33.0 in
/modules/common/client by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8784
- chore(deps-dev): bump
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)
from 7.1.0 to 7.5.0 in /modules/web by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8851
- chore(deps-dev): bump
[@&#8203;babel/preset-env](https://togithub.com/babel/preset-env) from
7.24.0 to 7.24.3 in /modules/web by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8868
- chore(deps-dev): bump node-gyp from 10.0.1 to 10.1.0 in /modules/web
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8857
- chore(deps-dev): bump stylelint-config-standard-scss from 13.0.0 to
13.1.0 in /modules/web by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8858
- chore(deps): bump github.com/go-openapi/spec from 0.20.4 to 0.21.0 in
/modules/api by [@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8862
- chore(deps): bump ace-builds from 1.32.7 to 1.32.9 in /modules/web by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8863
- chore(deps-dev): bump cypress from 13.7.1 to 13.7.2 in /modules/web by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8860
- chore(deps-dev): bump tar from 6.2.0 to 6.2.1 in /modules/web by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8856
- chore(deps): bump core-js from 3.36.0 to 3.36.1 in /modules/web by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8859
- chore(deps-dev): bump stylelint from 16.2.1 to 16.3.1 in /modules/web
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8861
- chore(deps-dev): bump ng-extract-i18n-merge from 2.11.0 to 2.11.1 in
/modules/web by [@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8866
- chore(deps-dev): bump
[@&#8203;types/node](https://togithub.com/types/node) from 20.12.2 to
20.12.3 in /modules/web by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[kubernetes/dashboard#8867

##### API

- fix: api schema and update kong chart config by
[@&#8203;floreks](https://togithub.com/floreks) in
[kubernetes/dashboard#8879
- fix(api): role/clusterole/podlist endpoints by
[@&#8203;floreks](https://togithub.com/floreks) in
[kubernetes/dashboard#8881

##### Helm Chart

-   Update csrf secret handling.
It will no longer be regenerated on every helm run. Instead, it will use
a lookup function to make sure that the `private.key` value is not
empty. If secret will be deleted or key changed, then checksum
annotation on api/auth containers will trigger a rollout restart.
- Update kong `dns_order` configuration to include experimental `AAAA`
record for ipv6 lookup. It can potentially fix issues with accessing
Dashboard on IPv6-enabled cluster. Closes
[#&#8203;8855](https://togithub.com/kubernetes/dashboard/issues/8855)
- Reenable SA token automount for auth container. It is required to
initialize the in-cluster go client.
-   Bump API image to `1.4.1`
- Optimize kong deployment to minimize memory usage (down from ~250Mi to
~75Mi on start)
- feat(chart): add automountServiceAccountToken to deployment specs in
Helm chart by [@&#8203;jnoordsij](https://togithub.com/jnoordsij) in
[kubernetes/dashboard#8869
- feat(chart): allow setting priorityClassName on deployments by
[@&#8203;jnoordsij](https://togithub.com/jnoordsij) in
[kubernetes/dashboard#8870
- feat(chart): bump chart version to 7.2.0 by
[@&#8203;floreks](https://togithub.com/floreks) in
[kubernetes/dashboard#8882

#### New Contributors

- [@&#8203;jnoordsij](https://togithub.com/jnoordsij) made their first
contribution in
[kubernetes/dashboard#8869

**Full Changelog**:
kubernetes/dashboard@kubernetes-dashboard-7.1.3...kubernetes-dashboard-7.2.0

#### Installation

```sh
helm repo add kubernetes-dashboard https://kubernetes.github.io/dashboard/
helm upgrade --install kubernetes-dashboard kubernetes-dashboard/kubernetes-dashboard --create-namespace --namespace kubernetes-dashboard
```

#### Compatibility

| Kubernetes version | 1.27 | 1.28 | 1.29 |
|--------------------|-----|-----|-----|
| Compatibility            | ?   |   ?   |   ✓    |

-   `✓` Fully supported version range.
- `?` Due to breaking changes between Kubernetes API versions, some
features might not work correctly in the Dashboard.

#### Images

    docker.io/kubernetesui/dashboard-api:1.4.1
    docker.io/kubernetesui/dashboard-auth:1.1.2
    docker.io/kubernetesui/dashboard-metrics-scraper:1.1.1
    docker.io/kubernetesui/dashboard-web:1.2.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNzkuNCIsInVwZGF0ZWRJblZlciI6IjM3LjI3OS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9taW5vciJdfQ==-->

Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants