Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes system components logs sanitization #1753

Closed
44past4 opened this issue May 8, 2020 · 68 comments
Closed

Kubernetes system components logs sanitization #1753

44past4 opened this issue May 8, 2020 · 68 comments
Assignees
Labels
kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/security Categorizes an issue or PR as relevant to SIG Security. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Milestone

Comments

@44past4
Copy link
Contributor

44past4 commented May 8, 2020

Enhancement Description

  • One-line enhancement description: Introduce a logging filter which could be applied to all Kubernetes system components logs to prevent various types of sensitive information from leaking via logs
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/1753-logs-sanitization
  • Primary contact (assignee): @44past4
  • Responsible SIGs: sig-instrumentation
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (1.20)
    • Beta release target (N/A)
    • Stable release target (N/A)
    • Deprecation target (1.24)
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 8, 2020
@44past4
Copy link
Contributor Author

44past4 commented May 8, 2020

/sig intrumentation

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 8, 2020

@44past4: The label(s) sig/intrumentation cannot be applied, because the repository doesn't have them

In response to this:

/sig intrumentation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@44past4
Copy link
Contributor Author

44past4 commented May 8, 2020

/sig instrumentation

@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 8, 2020
@44past4
Copy link
Contributor Author

44past4 commented May 14, 2020

/kind kep
/kind feature

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory kind/feature Categorizes issue or PR as related to a new feature. labels May 14, 2020
@palnabarun
Copy link
Member

palnabarun commented May 14, 2020

Hey there @44past4 -- 1.19 Enhancements Lead here. I wanted to check in and see if you think this Enhancement will be graduating to Alpha in 1.19?

In order to have this part of the release:

  1. The KEP PR must be merged in an implementable state
  2. The KEP must have test plans
  3. The KEP must have graduation criteria.

As an additional note, #1620 merged recently, adding production readiness review questions to the KEP template. We are not making it mandatory for the 1.19 release cycle, but it would be great if the PRR questionnaire is filled since the KEP PR is in flight.

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks! 🙂


The current release schedule is:

  • Monday, April 13: Week 1 - Release cycle begins
  • Tuesday, May 19: Week 6 - Enhancements Freeze
  • Thursday, June 25: Week 11 - Code Freeze
  • Thursday, July 9: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

@palnabarun
Copy link
Member

palnabarun commented May 18, 2020

Hi @44past4 ,

Tomorrow, Tuesday May 19 EOD Pacific Time is Enhancements Freeze

Will this enhancement be part of the 1.19 release cycle?

@palnabarun
Copy link
Member

palnabarun commented May 20, 2020

@44past4 -- Unfortunately, the deadline for the 1.19 Enhancement freeze has passed. For now, this is being removed from the milestone and 1.19 tracking sheet. If there is a need to get this in, please file an enhancement exception.

@palnabarun palnabarun added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label May 20, 2020
@fejta-bot
Copy link

fejta-bot commented Aug 18, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2020
@palnabarun
Copy link
Member

palnabarun commented Sep 1, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 1, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 13, 2020

Hi @44past4

Enhancements Lead here. Any plans for this in 1.20?

Thanks!
Kirsten

@44past4
Copy link
Contributor Author

44past4 commented Sep 17, 2020

Yes, we plan to work on this in 1.20.

@ehashman
Copy link
Member

ehashman commented Sep 17, 2020

/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 17, 2020
@kikisdeliveryservice kikisdeliveryservice added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 17, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 17, 2020

Thanks @44past4

Also, as a reminder to be included in a release:

I've also updated the description to link directly to the merged KEP.

Best,
Kirsten

@ehashman
Copy link
Member

ehashman commented Sep 17, 2020

/wg security-audit

@k8s-ci-robot k8s-ci-robot added the wg/security-audit Categorizes an issue or PR as relevant to WG Security Audit. label Sep 17, 2020
@MorrisLaw
Copy link
Member

MorrisLaw commented Sep 26, 2020

Hey @44past4 - 1.20 Enhancements Shadow here 👋

Just a friendly reminder, Enhancements Freeze is October 6th and if this KEP is intended for the 1.20 release, it still needs the following:

@ehashman
Copy link
Member

ehashman commented Oct 1, 2020

@44past4 please ensure you have opened a PR to address the above so this can be reviewed and merged by the enhancements freeze deadline, Oct. 6.

@ehashman
Copy link
Member

ehashman commented Jan 14, 2022

/assign
for deprecation

@ehashman
Copy link
Member

ehashman commented Jan 14, 2022

/kind deprecation
/remove-kind kep feature
/milestone v1.24

@k8s-ci-robot k8s-ci-robot added kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. and removed kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Jan 14, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 14, 2022
@k8s-ci-robot k8s-ci-robot removed the kind/feature Categorizes issue or PR as related to a new feature. label Jan 14, 2022
@gracenng gracenng added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 16, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jan 17, 2022

Hello @44past4 👋, 1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. This enhancement is targeting for deprecation for 1.24, is this correct?

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release
    • For record: KEP is already implemented at stage alpha & now marked for deprecation.
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would just need to update the following:

At the moment, the status of this enhancement is track as at risk. Please keep the issue description updated. Thank you!

@ehashman
Copy link
Member

ehashman commented Jan 21, 2022

Hi @Priyankasaggu11929,

No PRR questionnaire is required for deprecations. I will update the KEP at some point with the implementation history.

The PR removing the feature kubernetes/kubernetes#107207 is now merged.

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jan 24, 2022

@ehashman, Thanks so much for the clarification on PRR bit above ^ .

No PRR questionnaire is required for deprecations. I will update the KEP at some point with the implementation history.

With this, I will update the status of this enhancement to Tracked in the tracking sheet. It is all good for the upcoming 1.24 enhancements freeze. 🚀

@ehashman
Copy link
Member

ehashman commented Feb 3, 2022

The only thing remaining for this is to update the website documentation to remove references to this feature.

@chrisnegus
Copy link

chrisnegus commented Feb 11, 2022

Hi @44past4 👋 1.24 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu March 31, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@chrisnegus
Copy link

chrisnegus commented Mar 7, 2022

@ehashman @Priyankasaggu11929 Are either of you expecting to do the documentation updates to remove this feature. I would be happy to work on doing the actual removal of this feature from the docs if you like.

@ehashman
Copy link
Member

ehashman commented Mar 17, 2022

@husky-parul is going to do the documentation work for this. She'll update the website docs with the deprecation/removal.

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Mar 18, 2022

Hello @44past4 @husky-parul 👋

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

For note, the status of this enhancement is currently marked as tracked.

Kindly please let me know if I'm missing any open PRs other than the ones I linked above. Thank you so much!

@chrisnegus
Copy link

chrisnegus commented Mar 19, 2022

@husky-parul is going to do the documentation work for this. She'll update the website docs with the deprecation/removal.

Thanks @ehashman !

@husky-parul
Copy link
Contributor

husky-parul commented Mar 20, 2022

@valaparthvi
Copy link

valaparthvi commented Mar 21, 2022

Hi @ehashman 👋 1.24 Release Comms team here.

We have an opt-in process for the feature blog delivery. If you would like to publish a feature blog for this issue in this cycle, then please opt in on this tracking sheet.

The deadline for submissions and the feature blog freeze is scheduled for 01:00 UTC Wednesday 23rd March 2022 / 18:00 PDT Tuesday 22nd March 2022. Other important dates for delivery and review are listed here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.24#timeline.

For reference, here is the blog for 1.23.

Please feel free to reach out any time to me or on the #release-comms channel with questions or comments.

Thanks!

@chrisnegus
Copy link

chrisnegus commented Mar 23, 2022

Apologies for the delayed response. I am on PTO until March 22. I will get this done soon after that. Thanks

Thanks @husky-parul! There is still time before the March 31 deadline to open a placeholder PR. Let me know if you have any questions.

@chrisnegus
Copy link

chrisnegus commented Mar 24, 2022

@husky-parul Thanks for filing the draft PR!

@ehashman
Copy link
Member

ehashman commented Apr 20, 2022

As the KEP stage was already updated and all associated PRs have closed, this issue can now be closed!

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 20, 2022

@ehashman: Closing this issue.

In response to this:

As the KEP stage was already updated and all associated PRs have closed, this issue can now be closed!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Priyankasaggu11929 Priyankasaggu11929 removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/security Categorizes an issue or PR as relevant to SIG Security. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
None yet
Development

No branches or pull requests