Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor Nominated node during the new scheduling cycle #1923

Closed
chendave opened this issue Aug 6, 2020 · 34 comments
Closed

Honor Nominated node during the new scheduling cycle #1923

chendave opened this issue Aug 6, 2020 · 34 comments
Assignees
Labels
sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@chendave
Copy link
Member

chendave commented Aug 6, 2020

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 6, 2020
@chendave
Copy link
Member Author

chendave commented Aug 6, 2020

/sig scheduling
/assign

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 6, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 13, 2020

Hi @chendave

Enhancements Lead here. Do you still plan to target this for alpha in 1.20?

Thanks!
Kirsten

@chendave
Copy link
Member Author

chendave commented Sep 14, 2020

@kikisdeliveryservice I have internal dependency on this, let me check the 1.20 release schedule first, and properly need to defer the milestone for this.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 27, 2020

Hi @chendave

Any updates on whether this will be included in 1.20?

Enhancements Freeze is October 6th and by that time we require:

The KEP must be merged in an implementable state
The KEP must have test plans
The KEP must have graduation criteria
The KEP must have an issue in the milestone

Thanks
Kirsten

@chendave
Copy link
Member Author

chendave commented Sep 28, 2020

thank you @kikisdeliveryservice , I have updated the milestone to 1.21.

@kikisdeliveryservice kikisdeliveryservice added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 28, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 28, 2020

Thank you for the update!!

@fejta-bot
Copy link

fejta-bot commented Dec 28, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 28, 2020
@chendave
Copy link
Member Author

chendave commented Dec 28, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 28, 2020
@annajung annajung added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 27, 2021
@annajung annajung added this to the v1.21 milestone Jan 27, 2021
@mvortizr
Copy link

mvortizr commented Feb 20, 2021

/assign

@chendave
Copy link
Member Author

chendave commented Feb 22, 2021

@kikisdeliveryservice I guess I need close this issue since the PR has been merged? see: kubernetes/kubernetes#93179

@chendave
Copy link
Member Author

chendave commented Feb 22, 2021

@kikisdeliveryservice @mvortizr let me close this issue, please feel free to reopen for some purpose like tracking.

@annajung
Copy link
Member

annajung commented Feb 24, 2021

Hi @chendave , 1.21 Enhancements Lead here.
An Enhancement issue is kept open until the feature graduates to stable and all work related to this enhancement have been completed.

The enhancements team is tracking this enhancement with the understanding that it has graduated to alpha. You would leave this open until your work for beta and stable merges. When all work has completed, you would also have to update your KEP to reflect that this enhancement has been implemented.

@annajung annajung reopened this Feb 24, 2021
@kendallroden
Copy link
Contributor

kendallroden commented Feb 24, 2021

Hi @chendave ,
Following up on Anna's comment above, since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

  • Tuesday, March 9th: Week 9 - Code Freeze
  • Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline
    • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.
  • As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

@chendave
Copy link
Member Author

chendave commented Feb 25, 2021

@kendallroden @annajung thanks for the clarification.

@reylejano
Copy link
Member

reylejano commented Mar 8, 2021

Hello @chendave , 1.21 Docs lead here.
Does this enhancement work planned for 1.21 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.21 branch in the k/website repo. This PR can be just a placeholder at this time and must be created by March 16 EOD PST
Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@JamesLaverack JamesLaverack added this to the v1.22 milestone Jun 3, 2021
@PI-Victor
Copy link
Member

PI-Victor commented Jun 22, 2021

Hello @chendave 👋, 1.22 Docs release lead here.
I see above that this change did not need docs, however can you confirm it does not for 1.22 release?

If it does, please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.
 Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

@chendave
Copy link
Member Author

chendave commented Jun 23, 2021

Hi @PI-Victor , confirmed, no docs needed, thanks for the reminder!

@Huang-Wei
Copy link
Member

Huang-Wei commented Jun 23, 2021

@chendave not quite, you'd need to at least update the default feature gate value to true.

(tip: search PreferNominatedNode in the path "content/en")

@jrsapi
Copy link

jrsapi commented Jun 24, 2021

Greetings @chendave ,
Enhancement shadow checking with a reminder that we are 2 weeks away from code freeze (July 8, 2021). Can you confirm if the following k/k PR is all that is needed for the implementation of this enhancement for the 1.22 milestone?

Thanks!

@chendave
Copy link
Member Author

chendave commented Jun 24, 2021

you'd need to at least update the default feature gate value to true.

@Huang-Wei I guess this should be auto-generated? just like this one: https://github.com/kubernetes/website/pull/25386/files

Anyway, I will send one for review today.

@chendave
Copy link
Member Author

chendave commented Jun 24, 2021

I see it, looks like I only need to update the feature gate, thanks for the guidance! @Huang-Wei

@chendave
Copy link
Member Author

chendave commented Jun 24, 2021

@jrsapi still need another doc PR: kubernetes/website#28597.

@chendave
Copy link
Member Author

chendave commented Jul 2, 2021

@jrsapi , the doc change has been covered by kubernetes/website#28644, no more changes is left for 1.22.

@jrsapi
Copy link

jrsapi commented Jul 6, 2021

@chendave Reminder that the code freeze is Thursday, July 7th and Docs Placeholder PR is Friday, July 8th. This is to notify that with the k/k PR's both merged, and a Docs PR is in place, this KEP is marked "Tracked" for the 1.22 milestone.

Thanks!

@salaxander salaxander added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 19, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Nov 17, 2021

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2021
@Huang-Wei
Copy link
Member

Huang-Wei commented Nov 17, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Feb 15, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 15, 2022
@chendave
Copy link
Member Author

chendave commented Feb 16, 2022

Can I close this one? since the feature is GA-ed.

@k8s-triage-robot
Copy link

k8s-triage-robot commented Mar 18, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 18, 2022
@Huang-Wei
Copy link
Member

Huang-Wei commented Mar 18, 2022

@chendave before closing this, could you check the criteria of graduating a KEP, IIUC, at least we should change the status in kep.yaml to implemented.

@Huang-Wei
Copy link
Member

Huang-Wei commented Mar 18, 2022

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests