Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod conditions around completion of pod sandbox creation and pod networking configuration #3085

Open
4 of 8 tasks
ddebroy opened this issue Dec 14, 2021 · 18 comments
Open
4 of 8 tasks
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@ddebroy
Copy link
Member

ddebroy commented Dec 14, 2021

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 14, 2021
@ddebroy
Copy link
Member Author

ddebroy commented Dec 14, 2021

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 14, 2021
@gracenng gracenng added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 17, 2022
@gracenng gracenng added this to the v1.24 milestone Jan 17, 2022
@rhockenbury
Copy link

rhockenbury commented Jan 20, 2022

Hi @ddebroy! 1.24 Enhancements team here. Just checking in as we approach enhancements freeze at 18:00pm PT on Thursday Feb 3rd. This enhancement is targeting alpha for 1.24.

Here’s where this enhancement currently stands:

Please plan to merge #3087 by enhancements freeze to complete the above items. The status of this enhancement is at risk. Thanks!

@ddebroy
Copy link
Member Author

ddebroy commented Feb 1, 2022

PRR for the KEP is complete for 1.24. Waiting on final reviews from sig-node.

@gracenng
Copy link
Member

gracenng commented Feb 4, 2022

The Enhancements Freeze is now in effect and this enhancement is removed from the release.
Please feel free to file an exception.

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.24 milestone Feb 4, 2022
@gracenng gracenng added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Feb 4, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented May 5, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 5, 2022
@ddebroy
Copy link
Member Author

ddebroy commented May 5, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 5, 2022
@Priyankasaggu11929 Priyankasaggu11929 added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jun 10, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jun 10, 2022

/milestone v1.25

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 10, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jun 10, 2022

Hello @ddebroy 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would need to update the open KEP PR #3087 for following & get it merged by Enhancements Freeze:

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@ddebroy
Copy link
Member Author

ddebroy commented Jun 13, 2022

I have updated the Test Plan section as recommended based on the latest template pointed out above.

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jun 14, 2022

Thanks for the quick update, @ddebroy 🙂

@ddebroy ddebroy changed the title Pod conditions around starting and completion of pod sandbox creation Pod conditions around completion of pod sandbox creation and pod networking configuration Jun 17, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jun 23, 2022

With KEP PR #3087 merged, the enhancement is ready for the 1.25 Enhancements Freeze.

For note, the status is now marked as tracked. Thank you so much! 🙂

@didicodes
Copy link

didicodes commented Jul 13, 2022

Hello @ddebroy 👋, 1.25 Release Docs Shadow here.

This enhancement is marked as ‘Needs Docs’ for the 1.25 release. Please follow the steps detailed in the documentation to open a PR against the dev-1.25 branch in the k/website repo. This PR can be just a placeholder at this time and must be created by August 4.


Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. Thank you!

@parul5sahoo
Copy link
Member

parul5sahoo commented Jul 22, 2022

Hi @ddebroy 👋

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

Please verify, if there are any additional k/k PRs besides the ones listed above.

Please plan to get the open k/k merged by the code freeze deadline. The status of the enhancement is currently marked as at-risk.

Please also update the issue description with the relevant links for tracking purpose. Thank you so much!

@parul5sahoo
Copy link
Member

parul5sahoo commented Aug 1, 2022

Hi @ddebroy 👋

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022, which is in two days.

please ensure that you have the following PR(s) merged before that :-

Thanks

@ddebroy
Copy link
Member Author

ddebroy commented Aug 1, 2022

kubernetes/kubernetes#111358 has merged!

@parul5sahoo
Copy link
Member

parul5sahoo commented Aug 2, 2022

Thanks @ddebroy now the status is marked as tracked.

@rhockenbury rhockenbury added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 11, 2022
@lujinda
Copy link

lujinda commented Sep 14, 2022

excuse me. If this Condition is added, how can I distinguish whether it meets the PodHasNetwork condition for the existing Pod? @ddebroy

@ddebroy
Copy link
Member Author

ddebroy commented Sep 15, 2022

hi @lujinda can you please clarify your question (potentially with an example) a bit? Are you referring to how to find out if the condition was set?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
No open projects
Development

No branches or pull requests

9 participants