Extend metrics stability

[logicalhan]

Enhancement Description

• One-line enhancement description (can be used as a release note):
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/3498-extending-stability
• Discussion Link: wg-reliability meeting notes
• Primary contact (assignee): logicalhan
• Responsible SIGs: instrumentation
• Enhancement target (which target equals to which milestone):
  • Alpha release target: 1.26
  • Beta release target: 1.27
  • Stable release target: 1.28
• Alpha
  • KEP (k/enhancements) update PR(s): KEP-3498: Extend stability classes for Kubernetes metrics framework #3499
  • Code (k/k) update PR(s):
    • Extend the metrics stability framework to support additional parses kubernetes#112676
    • account for timing ratio histogram function calls kubernetes#113027
    • unparameterize 'webhook' from conversion metrics since it's the only one kubernetes#113022
    • add support for parsing gauge func kubernetes#113014
    • add support for timing histograms and const labels kubernetes#112995
    • fix metric labels in cloud-provider metrics since it breaks static analysis kubernetes#112992
    • add explicit stability levels for shared metrics kubernetes#112991
    • add meta-metrics for metrics framework kubernetes#112907
    • order the output for stable metrics since we're supporting more than just stable now kubernetes#113123
    • add support for merging calls to Linear/Exponential Buckets kubernetes#113117
    • actually resolve the computations for buckets for static analysis kubernetes#113115
  • Docs (k/website) update PR(s):
    • Add documentation of all prometheus metrics in core Kubernetes website#37522
• Beta
  • KEP (k/enhancements) update PR(s):
    • KEP-3498: adding beta graduation criteria for extending metric stability #3752
  • Code (k/k) update PR(s):
  • Docs (k/website) update(s):
    • add documentation for beta stability levels website#40061
    • add autogenerated documentation for metrics website#40191
• Stable
  • KEP (k/enhancements) update PR(s): add GA requirement for extending metrics stability #4041
  • Code (k/k) update PR(s):
    • [dependencies] update prometheus/client_golang v1.14.0 to v1.16.0 kubernetes#118689
    • promote beta metrics kubernetes#119264
    • Write process start time to prometheus options so that scraping clients can parse it first kubernetes#118820
  • Docs (k/website) update(s):
    • Autogen documented metrics for v1.28 website#42119
    • amend deprecation policy on stability framework website#42217

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[logicalhan]

/sig instrumentation

[logicalhan]

/lead-opted-in

[dashpole]

/assign @logicalhan

[rhockenbury]

/milestone v1.26

[ruheenaansari34]

Hello @logicalhan 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise).

Here's where this enhancement currently stands:

• KEP file using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable
• KEP has a updated detailed test plan section filled out
• KEP has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

• Update the PR KEP-3498: Extend stability classes for Kubernetes metrics framework #3499 to meet the requirements for Enhancements freeze and get it merged.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[logicalhan]

@ruheenaansari34 I've updated the KEP to use the new template. Would you mind reassessing it? I also have a PRR reviewer actively conducting reviews.

[logicalhan]

/lead-opted-in

[Atharva-Shinde]

Hello @logicalhan 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on Thursday, 16th June 2023.

Is this enhancement staying to stage beta for v1.28? This enhancement is targeting stage stable

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone:v1.28
• KEP readme has a updated detailed test plan section filled out
• KEP readme has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to update the following:

• Update kep.yaml with latest information.
• Add response for this question in the Scalability questionnaire of the KEP readme.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

[logicalhan]

/milestone v1.28

[Atharva-Shinde]

Hey @logicalhan
With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

[VibhorChinda]

Hello @logicalhan 👋, 1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[Rishit-dagli]

Hey @logicalhan , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023.

[Atharva-Shinde]

Hey again @logicalhan 👋

Here’s the enhancement’s state for the upcoming code freeze:

• All the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.
• All code related PR/s are merged or are in merge-ready state ( i.e they have approved and lgtm labels applied) by the code freeze deadline. This includes any tests related PR/s too.

For this enhancement, it looks like the following code related PR/s are open and they need to be merged or should be in merge-ready state before the code freeze commences :

• promote beta metrics kubernetes#119264

These are the code related PR/s that I found on this KEP issue

• [dependencies] update prometheus/client_golang v1.14.0 to v1.16.0 kubernetes#118689
• promote beta metrics kubernetes#119264
• Write process start time to prometheus options so that scraping clients can parse it first kubernetes#118820

Also please let me know if there are other PRs in k/k we should be tracking for this KEP.

As always, we are here to help if any questions come up. Thanks!

[VibhorChinda]

Hey @logicalhan , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023.
Thanks.

[Atharva-Shinde]

Hey @logicalhan 👋 Enhancements Lead here,
With all the code related PRs merged as per the issue description, this enhancement is now tracked for v1.28 Code Freeze!
kubernetes/kubernetes#118689
kubernetes/kubernetes#119264
kubernetes/kubernetes#118820

[logicalhan]

Hey @logicalhan , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023. Thanks.

kubernetes/website#42119

[VibhorChinda]

Hello @logicalhan 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 25th July 2023. Thank you!

[npolshakova]

/remove-label lead-opted-in

[logicalhan]

/close

(as completed)

[k8s-ci-robot]

@logicalhan: Closing this issue.

In response to this:

/close

(as completed)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.