New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipBlock for Network Policies #367

Closed
cmluciano opened this Issue Jul 28, 2017 · 26 comments

Comments

Projects
None yet
8 participants
@cmluciano
Member

cmluciano commented Jul 28, 2017

Feature Description

  • One-line feature description (can be used as a release note):
    • CIDR selector support for egress/ingress network policies
  • Primary contact (assignee): @cmluciano
  • Responsible SIGs: SIG-Network
  • Design proposal link (community repo): kubernetes/kubernetes#49978
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @caseydavenport @danwinship
  • Approver (likely from SIG/area to which feature belongs): @thockin
  • Feature target (which target equals to which milestone):
    • Beta release target (1.8)
    • Stable release target (1.11)

@cmluciano cmluciano added this to the 1.8 milestone Jul 28, 2017

@cmluciano cmluciano self-assigned this Jul 28, 2017

@cmluciano

This comment has been minimized.

Member

cmluciano commented Aug 25, 2017

code complete in kubernetes/kubernetes#50033.

TODO:

  • More e2es
  • Docs
@jdumars

This comment has been minimized.

Member

jdumars commented Sep 15, 2017

@cmluciano any update on missing docs? The PR is due today.

@jdumars

This comment has been minimized.

Member

jdumars commented Sep 18, 2017

@caseydavenport @cmluciano mentioned you as the contact for docs. We need them ASAP in order to make the 1.8 release docs.

@caseydavenport

This comment has been minimized.

Member

caseydavenport commented Sep 19, 2017

Docs PR is here: kubernetes/website#5529

@cmluciano cmluciano changed the title from [Beta] CIDR Selectors for Network Policies to [Beta] ipBlock for Network Policies Sep 25, 2017

@cmluciano

This comment has been minimized.

Member

cmluciano commented Sep 25, 2017

Docs fixed in kubernetes/website#5473

@cmluciano

This comment has been minimized.

Member

cmluciano commented Oct 23, 2017

this was merged for 1.8

@cmluciano cmluciano closed this Oct 23, 2017

@cmluciano cmluciano modified the milestones: 1.8, next-milestone Oct 23, 2017

@cmluciano cmluciano added stage/stable and removed stage/beta labels Oct 23, 2017

@cmluciano

This comment has been minimized.

Member

cmluciano commented Oct 23, 2017

reopening for tracking stable

@cmluciano cmluciano reopened this Oct 23, 2017

@cmluciano cmluciano changed the title from [Beta] ipBlock for Network Policies to [GA] ipBlock for Network Policies Oct 23, 2017

@idvoretskyi

This comment has been minimized.

Member

idvoretskyi commented Jan 15, 2018

@cmluciano

This comment has been minimized.

Member

cmluciano commented Jan 16, 2018

This is still under discussion in the mailing list.

@idvoretskyi

This comment has been minimized.

Member

idvoretskyi commented Jan 22, 2018

@cmluciano any progress?

@cmluciano

This comment has been minimized.

Member

cmluciano commented Jan 22, 2018

Yes, from our mailing list conversations this feature with not GA in 1.10. We will continue discussing potential for future releases on the sig-network mailing list.

@idvoretskyi

This comment has been minimized.

Member

idvoretskyi commented Jan 22, 2018

@cmluciano got it, will mark with 1.10 milestone and keep beta for now.

PS. The same is for #366 (comment)

@idvoretskyi idvoretskyi modified the milestones: next-milestone, v1.10 Jan 22, 2018

@idvoretskyi

This comment has been minimized.

Member

idvoretskyi commented Jan 22, 2018

@cmluciano also updated the description to plan GA for 1.11 (for both features). Correct me if I wrong.

@idvoretskyi idvoretskyi changed the title from [GA] ipBlock for Network Policies to ipBlock for Network Policies Jan 22, 2018

@cmluciano

This comment has been minimized.

Member

cmluciano commented Jan 22, 2018

There is ongoing discussion on NetworkPolicy as a whole. Can we hold off on marking a stable milestone until these conversations conclude?

@idvoretskyi

This comment has been minimized.

Member

idvoretskyi commented Jan 22, 2018

@cmluciano please, do.

@idvoretskyi idvoretskyi modified the milestones: v1.10, next-milestone Jan 29, 2018

@justaugustus

This comment has been minimized.

Member

justaugustus commented Apr 16, 2018

@cmluciano
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

  • Description
  • Milestone
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

cc @idvoretskyi

@justaugustus justaugustus removed this from the next-milestone milestone Jul 2, 2018

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jul 30, 2018

This feature current has no milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Once this feature is appropriately updated, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.


Please note that Features Freeze is tomorrow, July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

P.S. This was sent via automation

@danwinship

This comment has been minimized.

danwinship commented Aug 31, 2018

doh, we did all of the discussion for this feature on the egress PR (#366) and forgot to update this PR as well.

Let's see if this still works:

/milestone v1.12
/remove-stage beta
/stage stable

@danwinship

This comment has been minimized.

danwinship commented Aug 31, 2018

@justaugustus, @kacole2, @robertsandoval, @rajendar38 This was supposed to have been tracked for 1.12 but we basically forgot that we had two separate feature PRs. All of the work is done, including tests and docs.

@danwinship

This comment has been minimized.

danwinship commented Aug 31, 2018

(ping @cmluciano)

justaugustus pushed a commit to justaugustus/features that referenced this issue Sep 3, 2018

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Sep 7, 2018

@danwinship I've got ahead and added this to the tracking sheet after seeing @tpepper +1 on the exception filed.

@danwinship

This comment has been minimized.

danwinship commented Sep 7, 2018

@kacole2 Thanks! It probably should have milestone v1.12 too?

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Sep 7, 2018

@danwinship it should but I don't have those powers yet.
@justaugustus can you add the correct labels?

@justaugustus

This comment has been minimized.

Member

justaugustus commented Sep 7, 2018

Fixed!
/milestone v1.12

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Sep 28, 2018

/close

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Sep 28, 2018

@kacole2: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment