Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubelet limit of Parallel Image Pulls #3673

Open
8 of 12 tasks
ruiwen-zhao opened this issue Dec 2, 2022 · 73 comments
Open
8 of 12 tasks

Kubelet limit of Parallel Image Pulls #3673

ruiwen-zhao opened this issue Dec 2, 2022 · 73 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Milestone

Comments

@ruiwen-zhao
Copy link
Contributor

ruiwen-zhao commented Dec 2, 2022

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 2, 2022
@ruiwen-zhao
Copy link
Contributor Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 2, 2022
@pacoxu
Copy link
Member

pacoxu commented Dec 22, 2022

@ruiwen-zhao ruiwen-zhao changed the title [WIP] Kubelet limit of Parallel Image Pulls Kubelet limit of Parallel Image Pulls Jan 6, 2023
@wojtek-t
Copy link
Member

/lead opted-in
/milestone v1.27

@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jan 26, 2023
@wojtek-t
Copy link
Member

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 26, 2023
@marosset marosset added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 31, 2023
@marosset
Copy link
Contributor

Hello @pacoxu & @ruiwen-zhao 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for v1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this enhancement, it looks like #3713 will address most of these requirements.
Please be sure to also:

  • Update the status to implemnetable in the kep.yaml (when ready)

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well.
Thank you!

@ruiwen-zhao
Copy link
Contributor Author

Hello @pacoxu & @ruiwen-zhao 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for v1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this enhancement, it looks like #3713 will address most of these requirements. Please be sure to also:

  • Update the status to implemnetable in the kep.yaml (when ready)

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

Updated the KEP PR #3713 to change the status to implemnetable. Once it is merged then all of the requirements will be addressed.

@marosset
Copy link
Contributor

marosset commented Feb 7, 2023

Thanks @ruiwen-zhao - this enhancement is ready to be tracked for v1.27

@marosset marosset added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 7, 2023
@pacoxu
Copy link
Member

pacoxu commented Feb 13, 2023

/assign @pacoxu @ruiwen-zhao

@ruiwen-zhao
Copy link
Contributor Author

Draft document update: kubernetes/website#39732

@mickeyboxell
Copy link

Hi @ruiwen-zhao @pacoxu 👋, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

Please feel free to reach out with any questions. Thanks!

@ruiwen-zhao
Copy link
Contributor Author

Hi @ruiwen-zhao @pacoxu 👋, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

Please feel free to reach out with any questions. Thanks!

Is kubernetes/website#39732 sufficient for now?

@marosset
Copy link
Contributor

marosset commented Mar 8, 2023

Hi @ruiwen-zhao @pacoxu 👋,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

Please let me know if there are any other PRs in k/k I should be tracking for this KEP.
I see the following PR was closed (kubernetes/kubernetes#112242) - Is it going to be replaced with another PR?

As always, we are here to help should questions come up. Thanks!

@ruiwen-zhao
Copy link
Contributor Author

Hi @marosset

The PR is kubernetes/kubernetes#115220, which has been merged already. Thanks!

@SergeyKanzhelev
Copy link
Member

this will be progressing to beta in 1.28 as per the sig node meeting 5/2/2023

/milestone v1.28

@k8s-ci-robot k8s-ci-robot removed this from the v1.27 milestone May 5, 2023
@salehsedghpour
Copy link
Contributor

Hey again @ruiwen-zhao and @pacoxu 👋 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November.

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Please update the Issue description to include all the related PRs (including kubernetes/kubernetes#120229, I guess) of this KEP under beta section in the Github Issue description. The status for this KEP is currently at risk for code freeze.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@a-mccarthy
Copy link

Hi @ruiwen-zhao @pacoxu, 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here is the 1.29 calendar

@pacoxu
Copy link
Member

pacoxu commented Oct 30, 2023

We only want to add some e2e test. Is the deadline of this to be next week(Test Freeze) then? I will send the PR ASAP.

@pacoxu
Copy link
Member

pacoxu commented Oct 30, 2023

I opened kubernetes/kubernetes#121604. I still need some more test.

@salehsedghpour
Copy link
Contributor

@pacoxu , I just doubled check this case. If the PR includes any net-new changes, in your case kubernetes/kubernetes#120229, it needs to be merged by the code freeze date even if it includes some tests. But if there is a PR that that basically just cover some tests, it can be merged by the Test Freeze.

So regarding this KEP, I'm checking kubernetes/kubernetes#120229 this PR. Is this the wrong PR that I'm looking in? And is there any other PR in k/k that I'm missing. I would appreciate it if you can update the issue description with all related PRs.

@npolshakova
Copy link

Hello @pacoxu 👋 1.29 Enhancements lead here,

Unfortunately, the implementation (code related) PR (kubernetes/kubernetes#120229 ) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the 1.29 milestone.

If you still wish to progress this enhancement in 1.29, please file an exception request. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.29 milestone Nov 1, 2023
@sftim
Copy link
Contributor

sftim commented Dec 5, 2023

BTW, this issue description doesn't yet link to the actual KEP text.

@salehsedghpour
Copy link
Contributor

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 6, 2024
@SergeyKanzhelev
Copy link
Member

/stage beta
/milestone v1.30

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 27, 2024
@salehsedghpour
Copy link
Contributor

Hello @pacoxu and @ruiwen-zhao , 1.30 Enhancements team here! Is this enhancement targeting 1.30? If it is, can you follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board? Thanks!

@ruiwen-zhao
Copy link
Contributor Author

Hello @pacoxu and @ruiwen-zhao , 1.30 Enhancements team here! Is this enhancement targeting 1.30? If it is, can you follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board? Thanks!

Yep I think #4452 will address everything. I will chase for approvals. Thanks!

@mrunalp
Copy link
Contributor

mrunalp commented Feb 1, 2024

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 1, 2024
@pnbrown
Copy link

pnbrown commented Feb 7, 2024

Hello @ruiwen-zhao @pacoxu 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage beta for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • There is an unanswered question here

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@ruiwen-zhao
Copy link
Contributor Author

Hello @ruiwen-zhao @pacoxu 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage beta for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • There is an unanswered question here

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

Sent #4494 to answer the question.

@pnbrown
Copy link

pnbrown commented Feb 9, 2024

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

@Princesso
Copy link

Hello @ruiwen-zhao, @pacoxu , 👋 1.30 Docs Shadow here.
Does this enhancement work planned for 1.30 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against the dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@Checksumz
Copy link

Hi @ruiwen-zhao ,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@ruiwen-zhao
Copy link
Contributor Author

Hello @ruiwen-zhao, @pacoxu , 👋 1.30 Docs Shadow here. Does this enhancement work planned for 1.30 require any new docs or modifications to existing docs? If so, please follow the steps here to open a PR against the dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

There is an existing doc already. I think the only thing we need to do is to change it to Beta once we are ready.

@ruiwen-zhao
Copy link
Contributor Author

Hi @ruiwen-zhao ,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository. The placeholder PR deadline is 27th February, 2024. Here's the 1.30 Release Calendar

@pacoxu already wrote a blog about this feature when it launched in Alpha: https://kubernetes.io/blog/2023/05/15/speed-up-pod-startup/#maximum-parallel-image-pulls-will-help-secure-your-node-from-overloading-on-image-pulling. I don't really think we need another one, unless @pacoxu maybe has different ideas?

@pacoxu
Copy link
Member

pacoxu commented Feb 18, 2024

@ruiwen-zhao +1 we may not have a new blog in this release cycle for this feature.

@Checksumz
Copy link

Thanks for your response @ruiwen-zhao @pacoxu

@Princesso
Copy link

Hi @mrunalp , @ruiwen-zhao thanks for your response. Could you please point me in the direction of the docs that exist already? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: Tracked
Status: Tracked
Status: Removed from Milestone
Status: Tracked for Enhancements Freeze
Development

No branches or pull requests