Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubelet limit of Parallel Image Pulls #3673

Open
11 of 14 tasks
ruiwen-zhao opened this issue Dec 2, 2022 · 87 comments
Open
11 of 14 tasks

Kubelet limit of Parallel Image Pulls #3673

ruiwen-zhao opened this issue Dec 2, 2022 · 87 comments
Assignees
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@ruiwen-zhao
Copy link
Contributor

ruiwen-zhao commented Dec 2, 2022

Enhancement Description

Related issues:

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 2, 2022
@ruiwen-zhao
Copy link
Contributor Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 2, 2022
@pacoxu
Copy link
Member

pacoxu commented Dec 22, 2022

@ruiwen-zhao ruiwen-zhao changed the title [WIP] Kubelet limit of Parallel Image Pulls Kubelet limit of Parallel Image Pulls Jan 6, 2023
@wojtek-t
Copy link
Member

/lead opted-in
/milestone v1.27

@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jan 26, 2023
@wojtek-t
Copy link
Member

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 26, 2023
@marosset marosset added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 31, 2023
@marosset
Copy link
Contributor

Hello @pacoxu & @ruiwen-zhao 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for v1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this enhancement, it looks like #3713 will address most of these requirements.
Please be sure to also:

  • Update the status to implemnetable in the kep.yaml (when ready)

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well.
Thank you!

@ruiwen-zhao
Copy link
Contributor Author

Hello @pacoxu & @ruiwen-zhao 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for v1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this enhancement, it looks like #3713 will address most of these requirements. Please be sure to also:

  • Update the status to implemnetable in the kep.yaml (when ready)

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

Updated the KEP PR #3713 to change the status to implemnetable. Once it is merged then all of the requirements will be addressed.

@marosset
Copy link
Contributor

marosset commented Feb 7, 2023

Thanks @ruiwen-zhao - this enhancement is ready to be tracked for v1.27

@marosset marosset added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 7, 2023
@pacoxu
Copy link
Member

pacoxu commented Feb 13, 2023

/assign @pacoxu @ruiwen-zhao

@ruiwen-zhao
Copy link
Contributor Author

Draft document update: kubernetes/website#39732

@mickeyboxell
Copy link

Hi @ruiwen-zhao @pacoxu 👋, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

Please feel free to reach out with any questions. Thanks!

@ruiwen-zhao
Copy link
Contributor Author

Hi @ruiwen-zhao @pacoxu 👋, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

Please feel free to reach out with any questions. Thanks!

Is kubernetes/website#39732 sufficient for now?

@marosset
Copy link
Contributor

marosset commented Mar 8, 2023

Hi @ruiwen-zhao @pacoxu 👋,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

Please let me know if there are any other PRs in k/k I should be tracking for this KEP.
I see the following PR was closed (kubernetes/kubernetes#112242) - Is it going to be replaced with another PR?

As always, we are here to help should questions come up. Thanks!

@ruiwen-zhao
Copy link
Contributor Author

Hi @marosset

The PR is kubernetes/kubernetes#115220, which has been merged already. Thanks!

@SergeyKanzhelev
Copy link
Member

this will be progressing to beta in 1.28 as per the sig node meeting 5/2/2023

/milestone v1.28

@k8s-ci-robot k8s-ci-robot removed this from the v1.27 milestone May 5, 2023
@ruiwen-zhao
Copy link
Contributor Author

Hello @ruiwen-zhao, @pacoxu , 👋 1.30 Docs Shadow here. Does this enhancement work planned for 1.30 require any new docs or modifications to existing docs? If so, please follow the steps here to open a PR against the dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

There is an existing doc already. I think the only thing we need to do is to change it to Beta once we are ready.

@ruiwen-zhao
Copy link
Contributor Author

Hi @ruiwen-zhao ,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository. The placeholder PR deadline is 27th February, 2024. Here's the 1.30 Release Calendar

@pacoxu already wrote a blog about this feature when it launched in Alpha: https://kubernetes.io/blog/2023/05/15/speed-up-pod-startup/#maximum-parallel-image-pulls-will-help-secure-your-node-from-overloading-on-image-pulling. I don't really think we need another one, unless @pacoxu maybe has different ideas?

@pacoxu
Copy link
Member

pacoxu commented Feb 18, 2024

@ruiwen-zhao +1 we may not have a new blog in this release cycle for this feature.

@Checksumz
Copy link

Thanks for your response @ruiwen-zhao @pacoxu

@Princesso
Copy link

Hi @mrunalp , @ruiwen-zhao thanks for your response. Could you please point me in the direction of the docs that exist already? Thank you!

@pnbrown
Copy link

pnbrown commented Feb 29, 2024

Hey again @ruiwen-zhao @pacoxu 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@salehsedghpour
Copy link
Contributor

Hello @ruiwen-zhao @pacoxu 👋 Enhancements team here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.30 milestone.

If you still wish to progress this enhancement in v1.30, please file an exception request. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.30 milestone Mar 6, 2024
@sreeram-venkitesh
Copy link
Member

Hi @ruiwen-zhao @pacoxu 👋, 1.31 Enhancements Lead here.

If you wish to progress this enhancement in v1.31, please have the SIG lead opt-in your enhancement by adding the lead-opted-in label and set the milestone to v1.31 before the Production Readiness Review Freeze.

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label May 15, 2024
@SergeyKanzhelev
Copy link
Member

/label lead-opted-in
/milestone v1.31

@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 23, 2024
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label May 23, 2024
@sreeram-venkitesh
Copy link
Member

Hello @ruiwen-zhao @pacoxu 👋, v1.31 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting for stage beta for v1.31 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.31. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline so that the PRR team has enough time to review your KEP before the enhancements freeze.

For this KEP, we need to do the following:

  • Update the latest-milestone to v1.31 here and the beta milestone to v1.31 here in the kep.yaml file.

The status of this enhancement is marked as at risk for enhancement freeze. But I can mark it as tracked as soon as the above changes are merged. Please make sure to get this done before the enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Let me know if you have any questions! Thank you!

@sreeram-venkitesh
Copy link
Member

@ruiwen-zhao @pacoxu Pinging as a slight reminder that we're approaching the enhancements freeze deadline on 14th June, this Friday!

@sreeram-venkitesh
Copy link
Member

Hello 👋, v1.31 Enhancements team here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in v1.31, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

@sreeram-venkitesh
Copy link
Member

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.31 milestone Jun 14, 2024
@sreeram-venkitesh
Copy link
Member

/label tracked/no

@k8s-ci-robot k8s-ci-robot added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Jun 24, 2024
@haircommander
Copy link
Contributor

@ruiwen-zhao @pacoxu do you plan on working on this in 1.32?

@haircommander
Copy link
Contributor

it seems this one is waiting on a test, and folks are working on it. I've moved it to Proposed for Consideration and we can see if we can move forward on it.

@tjons
Copy link
Contributor

tjons commented Sep 16, 2024

Hi, enhancements lead here - I inadvertently added this to the 1.32 tracking board 😀. Please readd it if you wish to progress this enhancement in 1.32.

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Sep 16, 2024
@pacoxu
Copy link
Member

pacoxu commented Sep 23, 2024

If kubernetes/kubernetes#127495 can be merged, we can restart the work of adding e2e test for this feature then.

I would update the test once there are some updates. This may be a little uncertain in the 1.32 release cycle, but I think it should be possible in 1.33.

@pacoxu
Copy link
Member

pacoxu commented Sep 23, 2024

After a quick review, the effort is not big and I think this can be done in v1.32.
@SergeyKanzhelev

I will update the KEP ASAP to make it in v1.32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
Status: Tracked
Status: Tracked
Status: Removed from Milestone
Status: Removed from Milestone
Status: Triage
Status: Removed from Milestone
Development

No branches or pull requests