Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client-go: Add metrics into informer #4346

Open
4 of 7 tasks
chenk008 opened this issue Nov 27, 2023 · 13 comments
Open
4 of 7 tasks

client-go: Add metrics into informer #4346

chenk008 opened this issue Nov 27, 2023 · 13 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Milestone

Comments

@chenk008
Copy link
Contributor

chenk008 commented Nov 27, 2023

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 27, 2023
@chenk008
Copy link
Contributor Author

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 27, 2023
@chenk008 chenk008 changed the title client-go: Add metrics for pendingNotifications in informer client-go: Add metrics into informer Nov 27, 2023
@chenk008
Copy link
Contributor Author

chenk008 commented Dec 1, 2023

@lzlaa
Copy link

lzlaa commented Jan 6, 2024

It's useful to find out whether there are unhandled events received by reflector.

@fedebongio
Copy link

/assign @logicalhan

@jpbetz
Copy link
Contributor

jpbetz commented Feb 2, 2024

/label lead-opted-in
/milestone v1.30

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 2, 2024
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 2, 2024
@salehsedghpour
Copy link
Contributor

salehsedghpour commented Feb 4, 2024

Hello @logicalhan 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage alpha for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just want to update the following but it's not required for alpha stage and it will serve for future stages:

  • Make sure that the filled README.md file is merged to the k/enhancements repo. Moreover, all questions in the PRR questionnaire need to be answered.
  • Make sure that the KEP status is marked as implementable and the latest-milestone is 1.30, while the reviewers and approvers are there.
  • Make sure that there is graduation criteria at least for alpha stage.
  • Make sure that there is a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here)

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well, I couldn't find any related PR regarding this KEP in k/enhancements. Thank you!

@chenk008

This comment was marked as outdated.

@chenk008

This comment was marked as outdated.

@salehsedghpour
Copy link
Contributor

Hello @logicalhan 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024. (In few hours) And I found the open PR #4349.

This enhancement is targeting for stage alpha for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just want to update the following but it's not required for alpha stage and it will serve for future stages:

  • Make sure that the filled README.md file is merged to the k/enhancements repo. Moreover, all questions in the PRR questionnaire need to be answered.
  • Make sure that the KEP status is marked as implementable and the latest-milestone is 1.30, while the reviewers and approvers are there.
  • Make sure that there is graduation criteria at least for alpha stage.
  • Make sure that there is a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here)

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well, I couldn't find any related PR regarding this KEP in k/enhancements. Thank you!

@salehsedghpour
Copy link
Contributor

Hello 👋, v1.30 Enhancements team here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in v1.30, please file an exception request. Thanks!

@salehsedghpour
Copy link
Contributor

/milestone clear

@drewhagen
Copy link
Member

drewhagen commented Feb 15, 2024

Hello @logicalhan 👋, 1.30 Docs Lead here.

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@Checksumz
Copy link

Hi @chenk008 ,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
Status: Tracked for Enhancements Freeze
Development

No branches or pull requests

9 participants