Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CPUManager policy option to restrict reservedSystemCPUs to system daemons and interrupt processing #4540

Open
2 of 4 tasks
jingczhang opened this issue Mar 7, 2024 · 22 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node.
Milestone

Comments

@jingczhang
Copy link
Contributor

jingczhang commented Mar 7, 2024

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Mar 7, 2024
jingczhang added a commit to nokia/kubernetes-enhancements that referenced this issue Mar 7, 2024
… to system daemons and interrupt processing

KEP issue link: kubernetes#4540

Signed-off-by: Jing Zhang <jing.c.zhang.ext@nokia.com>
@ffromani
Copy link
Contributor

Hi, thanks for filing the issue. Unfortunately the 1.30 release is already in code freeze, so the earliest possible version is 1.31.

@jingczhang
Copy link
Contributor Author

Added KEP PR link; changed release targets as adviced.

jingczhang added a commit to nokia/kubernetes-enhancements that referenced this issue May 7, 2024
… to system daemons and interrupt processing

KEP issue link: kubernetes#4540

Signed-off-by: Jing Zhang <jing.c.zhang.ext@nokia.com>
jingczhang added a commit to nokia/kubernetes-enhancements that referenced this issue May 8, 2024
… to system daemons and interrupt processing

KEP issue link: kubernetes#4540

Signed-off-by: Jing Zhang <jing.c.zhang.ext@nokia.com>
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 17, 2024
@ffromani
Copy link
Contributor

ffromani commented Jul 2, 2024

/remove-lifecycle stale

we're quite active here

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 2, 2024
jingczhang added a commit to nokia/kubernetes-enhancements that referenced this issue Sep 12, 2024
… to system daemons and interrupt processing

KEP issue link: kubernetes#4540

Signed-off-by: Jing Zhang <jing.c.zhang.ext@nokia.com>
jingczhang added a commit to nokia/kubernetes-enhancements that referenced this issue Sep 19, 2024
… to system daemons and interrupt processing

KEP issue link: kubernetes#4540

Signed-off-by: Jing Zhang <jing.c.zhang.ext@nokia.com>
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 30, 2024
@haircommander
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 30, 2024
@haircommander
Copy link
Contributor

/milestone v1.32
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Oct 1, 2024
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Oct 1, 2024
@tjons
Copy link
Contributor

tjons commented Oct 2, 2024

Hello @jingczhang 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting stage alpha for v1.32 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.32.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@ffromani
Copy link
Contributor

ffromani commented Oct 2, 2024

@jingczhang need to opt in the Production Readiness Review (PRR) flow, the deadline is tomorrow Oct 3, 2024. Just opting in is required, the actual review will happen later.
You need to add an extra yaml file prod-readiness/sig-node/4540.yaml whose content would be something like

kep-number: 4800
alpha:
  approver: "@soltysh"

example: https://github.com/kubernetes/enhancements/blob/4ef0377fca621dcd080d2757ba7ba4cde1f26b77/keps/prod-readiness/sig-node/4800.yaml

I think you can start adding @soltysh as approver, the PRR team will suggest rebalancing with different approver as they see fit.

EDIT: another example: https://github.com/kubernetes/enhancements/blob/2626c678b2c62b6814c0a73ce4c0e276dcdbed1e/keps/prod-readiness/sig-windows/4885.yaml

(note the above example is sig-windows, you will need to use sig-node)

@jingczhang
Copy link
Contributor Author

jingczhang commented Oct 2, 2024

Thank you @tjons and @ffromani, I have pushed the KEP update requesting PRR review.

k8s-ci-robot added a commit that referenced this issue Oct 10, 2024
KEP-4540: Add CPUManager policy option to restrict reservedSystemCPUs to system daemons and interrupt processing #4540
@tjons
Copy link
Contributor

tjons commented Oct 11, 2024

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

@chanieljdan
Copy link

Hi @jingczhang 👋, 1.32 Release Docs Lead here.

Does this enhancement work planned for 1.32 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@edithturn
Copy link

Hello @jingczhang , 👋🏼 this is Edith from the v1.32 Communications Team! 🙂

We’d love for you to consider writing a feature blog about your enhancement! ✍
Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024 🗓 . For more information about writing a blog, see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@ffromani
Copy link
Contributor

let's please add kubernetes/kubernetes#127506 among the code changes we need for alpha

@jingczhang
Copy link
Contributor Author

Hi @jingczhang 👋, 1.32 Release Docs Lead here.

Does this enhancement work planned for 1.32 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Hi @chanieljdan, thank you for the detailed instructions, I will create doc PR to add this new 'strict-cpu-reservation" option to the existing Kubelet CPU Manager static policy options https://kubernetes.io/docs/tasks/administer-cluster/cpu-management-policies/#static-policy-options.

@jingczhang
Copy link
Contributor Author

Hello @jingczhang , 👋🏼 this is Edith from the v1.32 Communications Team! 🙂

We’d love for you to consider writing a feature blog about your enhancement! ✍ Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024 🗓 . For more information about writing a blog, see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

Hi @edithturn, thank you for detailed instructions, yes, we do plan to write a bug for this feature. I will create a feature blog PR per your instruction.

@jingczhang
Copy link
Contributor Author

Hi @chanieljdan, please find the documentation PR for this feature:
kubernetes/website#48356

@jingczhang
Copy link
Contributor Author

Hi @edithturn, please find the blog PR for this feature:
kubernetes/website#48371

@tjons
Copy link
Contributor

tjons commented Oct 27, 2024

Hey again @jingczhang 👋 v1.32 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

Additionally, please let me know if there are any other PRs in k/k not listed in the description or not linked with this GitHub issue that we should track for this KEP, so that we can maintain accurate status.

The status of this enhancement is marked as at risk for code freeze.

If you anticipate missing code freeze, you can file an exception request in advance. Thank you!

@ffromani
Copy link
Contributor

@jingczhang could you please add kubernetes/kubernetes#127506 to the list of the code changes required to this KEP?

@jingczhang
Copy link
Contributor Author

jingczhang commented Oct 28, 2024

@jingczhang could you please add kubernetes/kubernetes#127506 to the list of the code changes required to this KEP?

Done. I hope you get this one in asap. Thank you.

@tjons
Copy link
Contributor

tjons commented Nov 4, 2024

With all PRs merged, this enhancement is now tracked for code freeze!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
Status: Tracked for code freeze
Status: Implemented
Development

No branches or pull requests

8 participants