Skip to content

Add CPUManager policy option to restrict reservedSystemCPUs to system daemons and interrupt processing #4540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
8 tasks done
jingczhang opened this issue Mar 7, 2024 · 45 comments · Fixed by kubernetes/kubernetes#130290
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@jingczhang
Copy link
Contributor

jingczhang commented Mar 7, 2024

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Mar 7, 2024
jingczhang pushed a commit to nokia/kubernetes-enhancements that referenced this issue Mar 7, 2024
… to system daemons and interrupt processing

KEP issue link: kubernetes#4540

Signed-off-by: Jing Zhang <jing.c.zhang.ext@nokia.com>
@ffromani
Copy link
Contributor

Hi, thanks for filing the issue. Unfortunately the 1.30 release is already in code freeze, so the earliest possible version is 1.31.

@jingczhang
Copy link
Contributor Author

Added KEP PR link; changed release targets as adviced.

jingczhang pushed a commit to nokia/kubernetes-enhancements that referenced this issue May 7, 2024
… to system daemons and interrupt processing

KEP issue link: kubernetes#4540

Signed-off-by: Jing Zhang <jing.c.zhang.ext@nokia.com>
jingczhang pushed a commit to nokia/kubernetes-enhancements that referenced this issue May 8, 2024
… to system daemons and interrupt processing

KEP issue link: kubernetes#4540

Signed-off-by: Jing Zhang <jing.c.zhang.ext@nokia.com>
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 17, 2024
@ffromani
Copy link
Contributor

ffromani commented Jul 2, 2024

/remove-lifecycle stale

we're quite active here

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 2, 2024
@kannon92 kannon92 moved this from Triage to Proposed for consideration in SIG Node 1.32 KEPs planning Aug 24, 2024
jingczhang pushed a commit to nokia/kubernetes-enhancements that referenced this issue Sep 12, 2024
… to system daemons and interrupt processing

KEP issue link: kubernetes#4540

Signed-off-by: Jing Zhang <jing.c.zhang.ext@nokia.com>
jingczhang pushed a commit to nokia/kubernetes-enhancements that referenced this issue Sep 19, 2024
… to system daemons and interrupt processing

KEP issue link: kubernetes#4540

Signed-off-by: Jing Zhang <jing.c.zhang.ext@nokia.com>
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 30, 2024
@haircommander
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 30, 2024
@haircommander haircommander moved this from Proposed for consideration to Considered for release in SIG Node 1.32 KEPs planning Oct 1, 2024
@haircommander
Copy link
Contributor

/milestone v1.32
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Oct 1, 2024
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Oct 1, 2024
@tjons
Copy link
Contributor

tjons commented Oct 2, 2024

Hello @jingczhang 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting stage alpha for v1.32 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.32.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@tjons tjons moved this to At risk for enhancements freeze in 1.32 Enhancements Tracking Oct 2, 2024
@ffromani
Copy link
Contributor

ffromani commented Oct 2, 2024

@jingczhang need to opt in the Production Readiness Review (PRR) flow, the deadline is tomorrow Oct 3, 2024. Just opting in is required, the actual review will happen later.
You need to add an extra yaml file prod-readiness/sig-node/4540.yaml whose content would be something like

kep-number: 4800
alpha:
  approver: "@soltysh"

example: https://github.com/kubernetes/enhancements/blob/4ef0377fca621dcd080d2757ba7ba4cde1f26b77/keps/prod-readiness/sig-node/4800.yaml

I think you can start adding @soltysh as approver, the PRR team will suggest rebalancing with different approver as they see fit.

EDIT: another example: https://github.com/kubernetes/enhancements/blob/2626c678b2c62b6814c0a73ce4c0e276dcdbed1e/keps/prod-readiness/sig-windows/4885.yaml

(note the above example is sig-windows, you will need to use sig-node)

@fykaa
Copy link
Member

fykaa commented Feb 4, 2025

Hello @jingczhang 👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage beta for v1.33 (correct me, if otherwise)
/stage beta

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.33.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 6th February 2025 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

  • Ensure that the KEP has undergone a production readiness review and has been merged into k/enhancements.

The status of this enhancement is marked as At risk for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@swatisehgal
Copy link
Contributor

Please update the issue description with the link to the PR (with KEP updates) for graduation to Beta.

@dipesh-rawat
Copy link
Member

Hi @jingczhang 👋, 1.33 Enhancements team here,

Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

The current status of this enhancement is marked as At risk for enhancement freeze. There are a few requirements mentioned in the comment #4540 (comment) that still need to be completed.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@dipesh-rawat
Copy link
Member

Hello @jingczhang 👋, 1.33 Enhancements team here.

Now that PR #5128 has been merged, all the KEP requirements are in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!
(cc: @fykaa)

/label tracked/yes

@k8s-ci-robot k8s-ci-robot added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 12, 2025
@dipesh-rawat dipesh-rawat moved this from At risk for enhancements freeze to Tracked for enhancements freeze in 1.33 Enhancements Tracking Feb 12, 2025
@ffromani ffromani moved this from Considered for release to Tracked in SIG Node 1.33 KEPs planning Feb 12, 2025
@rayandas
Copy link
Member

Hello @jingczhang 👋, v1.33 Docs Lead here.

Does this enhancement work planned for v1.33 require any new docs or modification to existing docs?

If so, please follow the steps here to open a PR against dev-1.33 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 27th February 2025 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@jingczhang
Copy link
Contributor Author

Hi @rayandas, I have created the doc PR kubernetes/website#49902 which changes the feature status from alpha to beta.

@rayandas
Copy link
Member

Thanks @jingczhang

@fykaa
Copy link
Member

fykaa commented Feb 28, 2025

Hey again @jingczhang 👋, v1.33 Enhancements team here,

Just checking in as we approach Code Freeze at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

If you anticipate missing code freeze, you can file an exception request in advance.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.

The status of this enhancement is marked as At risk for code freeze.

As always, we are here to help if any questions come up. Thanks!

@fykaa fykaa moved this from Tracked for enhancements freeze to Tracked for code freeze in 1.33 Enhancements Tracking Feb 28, 2025
@fykaa fykaa moved this from Tracked for code freeze to At risk for code freeze in 1.33 Enhancements Tracking Feb 28, 2025
@Udi-Hofesh
Copy link
Member

Hey @jingczhang 👋 -- this is Udi (@Udi-Hofesh) from the 1.33 Communications Team!

For the 1.33 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!

As you may be aware, feature blogs are a great way to communicate to users about features that fall into (but are not limited to) the following categories:

  • This introduces some breaking change(s)
  • This has significant impacts and/or implications to users
  • ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail 🎉

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 5th March, 2025? For more information about writing a blog, please find the blog contribution guidelines 📚

Tip

Some timelines to keep in mind:

  • 02:00 UTC Wednesday, 5th March, 2025: Feature blog PR freeze
  • Monday, 7th April, 2025: Feature blogs ready for review
  • You can find more in the release document

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@Udi-Hofesh
Copy link
Member

Hi @jingczhang 👋, 1.33 Communications Team here again!

This is a gentle reminder for the feature blog deadline mentioned above, which is 02:00 UTC Wednesday, 5th March, 2025. To opt in, please let us know and open a Feature Blog placeholder PR against k/website by the deadline. If you have any questions, please feel free to reach out to us!

Tip

Some timeline to keep in mind:

  • 02:00 UTC Wednesday, 5th March, 2025: Feature blog PR freeze
  • Monday, 7th April, 2025: Feature blogs ready for review
  • You can find more in the release document

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@jingczhang
Copy link
Contributor Author

Hi @Udi-Hofesh, we will simply move the KEP to beta in 1.33, we will not write a new blog. Thank you.

@Udi-Hofesh
Copy link
Member

Fair enough @jingczhang :) thank you!

@dipesh-rawat
Copy link
Member

Hi @jingczhang 👋, v1.33 Enhancements team here,

Just a quick friendly reminder as we approach the code freeze later this week, at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.

The current status of this enhancement is marked as At risk for code freeze. There are a few requirements mentioned in the comment #4540 (comment) that still need to be completed.

If you anticipate missing code freeze, you can file an exception request in advance. Thank you!

@ffromani
Copy link
Contributor

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Mar 19, 2025
@k8s-ci-robot
Copy link
Contributor

@ffromani: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dipesh-rawat
Copy link
Member

Hey @jingczhang 👋, 1.33 Enhancements team here,

With all the implementation(code related) PRs merged as per the issue description:

This enhancement is now marked as tracked for code freeze for the 1.33 Code Freeze!

Additionally, please let me know if there are any other PRs in k/k not listed in the description that we should track for this KEP, so that we can maintain accurate status.

@dipesh-rawat dipesh-rawat moved this from At risk for code freeze to Tracked for code freeze in 1.33 Enhancements Tracking Mar 20, 2025
@jingczhang
Copy link
Contributor Author

Hi @dipesh-rawat, we are all done for 1.33. Thank you.

@rayandas rayandas moved this from Tracked for code freeze to Tracked for Docs Freeze in 1.33 Enhancements Tracking Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Tracked for Docs Freeze
Status: Done
Status: Tracked for code freeze
Status: Done
Development

Successfully merging a pull request may close this issue.