Display PVC capacity usage using kubectl

[vkamra]

Feature Description

• One-line feature description (can be used as a release note): Display PVC capacity usage using kubectl top
• Primary contact (assignee): @vkamra
• Responsible SIGs: @kubernetes/sig-storage-feature-requests @kubernetes/sig-instrumentation-feature-requests
• Design proposal link (community repo):
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  @jingxu97
• Approver (likely from SIG/area to which feature belongs): sig-instrumentation
• Feature target (which target equals to which milestone):
  • Alpha release target: 1.10
  • Beta release target: 1.11
  • Stable release target:

[fgrzadkowski]

Is there a design doc for this? The idea for kubectl top was to expose metrics available in master metric API. How would it work for PVCs?

I think this feature has to be approved by someone from @kubernetes/sig-instrumentation-feature-requests.

[idvoretskyi]

@vkamra any updates about the feature status?

[vkamra]

@idvoretskyi @fgrzadkowski - doc has the proposal.

PVC metrics are now available in the kubelet summary API (added in 1.8). @verult is working on adding these into the metrics exposed by heapster.

This would allow us to implement kubetl top pvc to display PVC resource usage in the cluster.

[vkamra]

We discussed status in storage-sig - the heapster changes are being worked on but kubectl changes (not designed/discussed yet) are not currently planned for 1.9. @verult @jingxu97 - can you also update?

[brancz]

I would very much prefer if we can not keep extending heapster, and instead maybe use the metrics-server for these purposes.

Also somewhat relevant: kubernetes/kubernetes#55489

[fgrzadkowski]

@vkamra This should NOT be added to heapster. As @brancz suggested it should be added to master metric API and metric server if needed. We need to move kubectl to using it anyway. It seems that the proposal hasn't been approved. I'd suggest to wait with the implementation for the approval. Also, as suggested earlier - please include @kubernetes/sig-instrumentation-feature-requests in this discussion.

[vkamra]

@brancz @fgrzadkowski - that makes sense to me.

Going to let @verult and @jingxu97 comment here as well because I believe they've had more recent discussions about this with members from the instrumentation sig and I might have mis-spoke about extending heapster.

Also added sig-instrumentation as approver.

[verult]

Yes we synced up with @DirectXMan12 recently and the consensus is that anything kubectl top consumes should go into the metric-server.

I'm still working on adding logic in Heapster because it's required to expose PVCStats to StackDriver (because metric-server doesn't support sinks like Heapster does).

[idvoretskyi]

@vkamra @jingxu97 @kubernetes/sig-storage-feature-requests @kubernetes/sig-instrumentation-feature-requests any progress is expected on this feature?

[brancz]

@idvoretskyi indirectly. We're currently working on getting kubectl top to use the metrics server at all (kubernetes/kubernetes#56206). Once that's done, we can think of PVC stats for the metrics server. I'll put it on the list of topics for the next sig meeting.

[idvoretskyi]

@brancz do you plan this still for 1.10 (or 1.11+ releases are more likely)?

[brancz]

It depends on availability of resources, but my gut feeling says 1.11+.

[vkamra]

@verult - I believe you're looking at this. Could you assign to yourself (I don't have permissions to do that)

[idvoretskyi]

@vkamra just assigned @verult

[verult]

I was under the impression that others have made some effort in this direction, as I've mostly been focusing on exposing PVC stats in Heapster and StackDriver. If this is not the case I can definitely take a look at it once Metric Server is ready.

[Bradamant3]

@verult is this feature in for 1.10? If so, we also need docs information (here). If not, can you please target next or 1.11? Thanks! cc @idvoretskyi

[verult]

@Bradamant3 AFAIK there's no work being done for this release, so if anyone has permissions to change the milestone please move it to 1.11. I also may not be able to look at this feature for 1.11, unfortunately.

[justaugustus]

@verult @vkamra
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

• Description
• Milestone
• Assignee(s)
• Labels:
  • stage/{alpha,beta,stable}
  • sig/*
  • kind/feature

cc @idvoretskyi

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[justaugustus]

This feature current has no milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

• One-line feature description (can be used as a release note):
• Primary contact (assignee):
• Responsible SIGs:
• Design proposal link (community repo):
• Link to e2e and/or unit tests:
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
• Approver (likely from SIG/area to which feature belongs):
• Feature target (which target equals to which milestone):
  • Alpha release target (x.y)
  • Beta release target (x.y)
  • Stable release target (x.y)

Set the following:

• Description
• Assignee(s)
• Labels:
  • stage/{alpha,beta,stable}
  • sig/*
  • kind/feature

Once this feature is appropriately updated, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.

---

Please note that Features Freeze is tomorrow, July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

• Docs deadline (open placeholder PRs): 8/21
• Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

P.S. This was sent via automation

[verult]

AFAIK there are no plans for this in 1.12. Unfortunately I don't have edit access to the Feature Description up top

[justaugustus]

Thanks for the update, @verult! I've edited the description.

[justaugustus]

/remove-lifecycle stale

[kacole2]

Hi @verult
This enhancement has been tracked before, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.13. This release is targeted to be more ‘stable’ and will have an aggressive timeline. Please only include this enhancement if there is a high level of confidence it will meet the following deadlines:
Docs (open placeholder PRs): 11/8
Code Slush: 11/9
Code Freeze Begins: 11/15
Docs Complete and Reviewed: 11/27

Please take a moment to update the milestones on your original post for future tracking and ping @kacole2 if it needs to be included in the 1.13 Enhancements Tracking Sheet

Thanks!

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[sharkymcdongles]

Bump. This would be super useful.

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[christianhuening]

Has this been continued somewhere? It would be super useful

[ankitnayan]

How do you folks currently see the usage of pvc?

[blakebarnett]

I think the plan is to rely on plugins for this: https://github.com/yashbhutwala/kubectl-df-pv