Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break apart the kubernetes test tarball #714

Closed
ixdy opened this issue Jan 23, 2019 · 24 comments · Fixed by kubernetes/kubernetes#83093
Closed

Break apart the kubernetes test tarball #714

ixdy opened this issue Jan 23, 2019 · 24 comments · Fixed by kubernetes/kubernetes#83093
Assignees
Labels
sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@ixdy
Copy link
Member

ixdy commented Jan 23, 2019

Enhancement Description

  • One-line enhancement description (can be used as a release note): The mondo-tarball kubernetes-test.tar.gz which contained test binaries for all platforms is now deprecated. Test binaries are now distributed in platform-specific tarballs (such as kubernetes-test-linux-amd64.tar.gz).
  • Primary contact (assignee): @ixdy
  • Responsible SIGs: sig-testing, sig-release
  • Design proposal link (community repo): KEP sig-testing/20190118-breaking-apart-the-kubernetes-test-tarball
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which enhancement belongs): @spiffxp @tpepper
  • Enhancement target (which target equals to which milestone):

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 23, 2019
@ixdy
Copy link
Member Author

ixdy commented Jan 23, 2019

/sig testing
/sig release

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/release Categorizes an issue or PR as relevant to SIG Release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 23, 2019
@ixdy ixdy added this to the v1.14 milestone Jan 30, 2019
@claurence claurence added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 5, 2019
@spiffxp
Copy link
Member

spiffxp commented Feb 7, 2019

/stage beta
(this was a completely arbitrary best guess based on the fact that we plan on moving our CI to use this, and plan on following a deprecation timeline)

@npentrel
Copy link

npentrel commented Feb 22, 2019

Hey @ixdy 👋! I'm Naomi, a v1.14 docs release shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.14) due by Friday, March 1. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

@ixdy
Copy link
Member Author

ixdy commented Feb 22, 2019

It doesn't look like kubernetes-test.tar.gz is referenced anywhere on the website. I don't think we need to add anything for it at this time, either.

@ixdy
Copy link
Member Author

ixdy commented Feb 23, 2019

kubernetes/kubernetes#74065 has merged.

@OlegLoewen
Copy link

OlegLoewen commented Mar 26, 2019

So how exactly is now the URL to get the linux-amd64.tar release 1.14 ?

@ixdy
Copy link
Member Author

ixdy commented Mar 26, 2019

@OlegLoewen I don't fully understand what you are asking.

The release tarballs for 1.14 are in the same location as in previous releases, i.e. in the gs://kubernetes-release bucket (which is also linked from all release announcements, as well as on https://releases.k8s.io/).

The difference starting in 1.14 is that there are also platform-specific tarballs for the tests, e.g. there's a kubernetes-test-linux-amd64.tar.gz; previously there was only one tarball containing all platform-specific code, kubernetes-test.tar.gz.

@kacole2
Copy link
Member

kacole2 commented Apr 12, 2019

Hello @ixdy , I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.14 milestone Apr 12, 2019
@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 12, 2019
@ixdy
Copy link
Member Author

ixdy commented Apr 12, 2019

@kacole2 there aren't really alpha/beta/stable stages for this change.

The split test tarballs were implemented and the mondo test tarball was marked deprecated in v1.14, but no changes are planned for v1.15.

@justaugustus
Copy link
Member

justaugustus commented Apr 28, 2019

/assign @ixdy

@fejta-bot
Copy link

fejta-bot commented Jul 27, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 27, 2019
@spiffxp
Copy link
Member

spiffxp commented Jul 27, 2019

/remove-lifecycle stale
/unassign @ixdy
/assign

It's unlikely we're going to move this forward for v1.16. The next step would be removing the mondo tarball. At most I will announce its deprecation more loudly in anticipation of removing it in v1.17

@k8s-ci-robot k8s-ci-robot assigned spiffxp and unassigned ixdy Jul 27, 2019
@spiffxp
Copy link
Member

spiffxp commented Jul 27, 2019

/milestone v1.17

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Jul 27, 2019
@mrbobbytables
Copy link
Member

mrbobbytables commented Sep 23, 2019

👋 @spiffxp -- 1.17 Enhancements lead here. I know there isn't really a direct alpha/beta/stable mapping for this Enhancement, but I wanted to check in and see if you think it'd be graduating or major work being done in 1.17?

The current release schedule is:

  • Monday, September 23 - Release Cycle Begins
  • Tuesday, October 15, EOD PST - Enhancements Freeze
  • Thursday, November 14, EOD PST - Code Freeze
  • Tuesday, November 19 - Docs must be completed and reviewed
  • Monday, December 9 - Kubernetes 1.17.0 Released

Thanks!

@ixdy
Copy link
Member Author

ixdy commented Sep 23, 2019

yes, 1.16 didn't happen, but I'd like to remove the mondo test tarball completely for 1.17.

@mrbobbytables
Copy link
Member

mrbobbytables commented Sep 24, 2019

Thanks for the quick reply. I'll go ahead and add it to the tracking sheet 👍
/stage stable

@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Sep 24, 2019
@mrbobbytables mrbobbytables added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 24, 2019
@ixdy
Copy link
Member Author

ixdy commented Sep 24, 2019

kubernetes/kubernetes#83093 removes the deprecated mondo test tarball.

SIG Release automation moved this from Backlog to Done (1.17) Sep 25, 2019
@VineethReddy02
Copy link

VineethReddy02 commented Oct 21, 2019

@spiffxp @ixdy

I'm one of the v1.17 docs shadows.
Does this enhancement (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I’ll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, Nov 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

Thanks!

@daminisatya
Copy link
Member

daminisatya commented Nov 2, 2019

@ixdy I believe this enhancement is autoclosed since the PR is merged.

We still need this to be open. Can you please confirm if this enhancement requires docs?

@daminisatya daminisatya reopened this Nov 2, 2019
SIG Release automation moved this from Done (1.17) to In progress Nov 2, 2019
@ixdy
Copy link
Member Author

ixdy commented Nov 4, 2019

I don't think any docs changes are necessary. This pretty much only affects contributors, not end users, and likely most contributors won't notice this change at all.

@ixdy
Copy link
Member Author

ixdy commented Nov 4, 2019

I don't see any references to the test tarball in k/website or k/community, so nothing to do here, I think.

@daminisatya
Copy link
Member

daminisatya commented Nov 5, 2019

@ixdy Awesome! Thank you for the quick update

@ixdy
Copy link
Member Author

ixdy commented Dec 10, 2019

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 10, 2019

@ixdy: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SIG Release automation moved this from In progress to Done (1.18) Dec 10, 2019
@jeremyrickard jeremyrickard removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 3, 2020
@spiffxp spiffxp added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Aug 17, 2021
@rhockenbury rhockenbury removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

Successfully merging a pull request may close this issue.