kubeadm: graduate the kubeadm configuration

[neolit123]

Enhancement Description

• One-line enhancement description (can be used as a release note):

Iterate on the kubeadm configuration (API) until it graduates to GA

• Kubernetes Enhancement Proposal: (link to kubernetes/enhancements file, if none yet, link to PR) https://github.com/kubernetes/enhancements/tree/master/keps/sig-cluster-lifecycle/kubeadm/970-kubeadm-config
• Primary contact (assignee): @neolit123
• Responsible SIGs: Cluster-Lifecycle
• Enhancement target (which target equals to which milestone):
  • Alpha release target PAST
  • Beta release target 1.22 (v1beta3)
  • Stable release target TODO

---

1.15

for the 1.15 cycle we want to upgrade the config type from v1beta1 to v1beta2.
Umbrella issue for tracking this work:
kubernetes/kubeadm#1439

---

1.22

for the 1.22 cycle we want to upgrade the config type from v1beta2 to v1beta3.
Umbrella issue for tracking this work:
kubernetes/kubeadm#1796

KEP updates:

• sig-cluster-lifecycle: update the kubeadm config KEP for 1.22 #2627

[k8s-ci-robot]

@neolit123: There are no sig labels on this issue. Please add a sig label.

A sig label can be added by either:

1. mentioning a sig: @kubernetes/sig-<group-name>-<group-suffix>
   e.g., @kubernetes/sig-contributor-experience-<group-suffix> to notify the contributor experience sig, OR

2. specifying the label manually: /sig <group-name>
   e.g., /sig scalability to apply the sig/scalability label

Note: Method 1 will trigger an email to the group. See the group list.
The <group-suffix> in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rosti]

/assign

[rosti]

Thanks for creating the issue @neolit123 !

[neolit123]

@rosti
updated the description and title.

[craiglpeters]

@fabriziopandini and @luxas, Kubernetes 1.15 Enhancement Freeze is 4/30/2019. To be included in the Kubernetes 1.15 milestone, KEPs are required to be in an "Implementable" state with proper test plans and graduation criteria. Please submit any PRs needed to make this KEP adhere to inclusion criteria. If this will slip from the 1.15 milestone, please let us know so we can make appropriate tracking changes.

[neolit123]

@craiglpeters thanks for the heads up. done:
https://github.com/kubernetes/enhancements/blob/master/keps/sig-cluster-lifecycle/kubeadm/0023-kubeadm-config.md

[christianh814]

Hey @neolit123 and @rosti I'm the v1.15 docs shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Friday, May 31st. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

[neolit123]

hi @christianh814
this work will require minor updates on already existing links to the godocs documentation of the kubeadm API. we are going to have the PRs up before the 31st.

thanks for the heads up.

[craiglpeters]

Hi @rosti. Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

[makoscafee]

Hi, @neolit123 I am docs Lead.
Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must have placeholder docs PRs open.
Just friendly following up on this. Thanks

[rosti]

Thanks for the reminder @makoscafee and @craiglpeters !

[rosti]

@craiglpeters
kubernetes/kubernetes#77739
kubernetes/kubernetes#78403

@makoscafee
kubernetes/website#14607

Those are the PRs.

[jrsapi]

Greetings @neolit123!
1.22 Enhancement shadow checking in. The Enhancement freeze is this Thursday, 5/13. In reviewing your KEP, one item needing attention before the freeze:

• (PRR) Production readiness review needs to be approved. #prod-readiness channel on K8s slack can assist.

Thanks!

[neolit123]

@jrsapi hello,
the kubeadm API predates the PRR process. it was never done for it and is arguably not needed.
based on recent discussions, PRR was partially a no-op for another kubeadm KEP:
#2620 (comment)

i think the PRR process needs to be scoped more clearly and potentially be only mandatory for core functionality or opt-in for out-of-core.

[jrsapi]

Thanks for the link to the comment. I'll move the to "Tracked" in the Enhancement spreadsheet.

[ehashman]

i think the PRR process needs to be scoped more clearly and potentially be only mandatory for core functionality or opt-in for out-of-core.

This is already true; PRR is optional for out-of-tree components. We discussed this at the last PRR meeting.

[PI-Victor]

Hello @neolit123 👋, 1.22 Docs release lead here.

This enhancement is marked as ‘Needs Docs’ for 1.22 release.

Can you confirm that kubernetes/website#28010 is related to this KEP?
If there are any other changes that need docs updates, please open a PR against k/website dev-1.22 branch before Fri July 9, 11:59 PM PDT (docs placeholder PR deadline).
thank you

[neolit123]

That PR is not related. We have enough time to sent the website PRs for this work. Thank you for the reminder.

[jrsapi]

Greetings @neolit123,
Enhancement team shadow checking in with a few updates. Currently, we are tracking this PR for the 1.22 milestone. Are there any other PR's that are not linked that should be tracked?

A reminder about code freeze which is July 8th, 2021 11:59 PST. All implementation PR's must be code complete and merged before the deadline. Thanks for your partnership.

[neolit123]

Hi, we merged a lot of PRs and some are still pending review. A detailed list can be seen here: kubernetes/kubeadm#1796 Thanks for the reminder. EDIT: corrected wrong sub comment on issue.

[neolit123]

@jrsapi
we consider the work for this "feature" in 1.22 completed (minus docs).
the "feature" remains in "beta".

the full list of merged PRs is here:
kubernetes/kubeadm#1796

e2e tests are updated:
https://k8s-testgrid.appspot.com/sig-cluster-lifecycle-kubeadm

docs PR is pending /lgtm:
kubernetes/website#28360

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[neolit123]

/remove-lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[rhockenbury]

/milestone clear

[pacoxu]

v1beta4 candidate

• kubeadm: Support skipping addons image pull  kubernetes#114534 @ruquanzhao
• kubeadm: implementation of UpgradeConfiguration API types kubernetes#114062 @chendave
• kubeadm: implementation of ResetConfiguration API types kubernetes#113583 @chendave
• Support custom env in kubeadm ControlPlaneComponent kubeadm#2845
• add API support for controlling various timeouts during init / join kubeadm#2463
• handling of extraArgs which are allowed multiple times kubeadm#1601