Graduate IPv6 support to beta #1139

aojea · 2019-07-14T20:53:28Z

Graduate IPv6 support to beta, it was in alpha status since 1.9 and a CI system was added to avoid regressions and guarantee the quality

Ref: #1138

aojea · 2019-07-14T20:56:36Z

/cc @lachie83 @BenTheElder

aojea · 2019-07-20T09:36:24Z

I have to add a section to include the ipv6 jobs at least as part of the presubmits and to the release to avoid situations like #80388

dims · 2019-07-20T23:44:34Z

@aojea @khenidak Can we make sure at least two or more cloud providers work well with IPv6 (and have CI coverage)?

aojea · 2019-07-22T21:24:20Z

@dims let me add it to the KEP so it can be discussed in the reviews, I will try to finish it this week 😄

keps/sig-network/20190714-IPv6-beta-proposal.md

aojea · 2019-07-26T12:45:33Z

keps/sig-network/20190714-IPv6-beta-proposal.md

+## Proposal
+
+* Make kind IPv6 e2e jobs mandatory for all PRs
+* Have signal on IPv6 e2e jobs running in at least one Cloud Provider


@thockin @lachie83 is this feasible?
are those jobs available for all kubernetes members or are they only configured by the companies?

anyone can publish conformance signal to testgrid, we already have a KEP for that.
anyone can also donate resources for their cloud to be used by prow / kubernetes's own CI

... we apparently even have EKS clusters on prow.k8s.io today.

however, the fact that someone could do this doesn't mean they will ...

dims · 2019-07-26T12:50:32Z

keps/sig-network/20190714-IPv6-beta-proposal.md

+## Proposal
+
+* Make kind IPv6 e2e jobs mandatory for all PRs
+* Have signal on IPv6 e2e jobs running in at least one Cloud Provider


I'd request this to be changed to at least 2 cloud providers. please explicitly say that we need the results in the testgrid as well for the release team. ("signal" is not expressive enough i feel)

BenTheElder · 2019-07-26T17:49:47Z

keps/sig-network/20190714-IPv6-beta-proposal.md

+## Proposal
+
+* Make kind IPv6 e2e jobs mandatory for all PRs
+* Create IPv6 e2e jobs on at least 2 Cloud Providers and publish the results on testgrid


IMHO this (2 cloud provider IPv6 jobs) is potentially a pretty significant hurdle.

You can't just create e2e jobs on a provider, you need credits from the provider and a working system to deploy IPv6 clusters on them besides the CI glue.

Today we have some AWS quota and lots of GCP quota, for which we have kops tooling on AWS and a few options on GCE, neither of which sets of (tools, provider) do IPv6 clusters AFAIK.

Is there a concrete plan for this particular point? Otherwise I suspect this will block progress.

@BenTheElder we need to shop this around in the sig-cloudprovider and get volunteers to help

the main reason for asking this is - since beta means it's on by default, if its on by default but does not work on most of the cloud providers, it's not really useful.

Well, technically is on by default, you don't have to enable anything, you configure ipv6 address, it work in ipv6, you configure ipv4 address it works in ipv4.

@aojea we don't have a feature flag? hmmm

Right, I see that misunderstanding lately, this is not a feature as in typical software development. When you develop your application you usually don't care about the network protocol, what @leblancd and others implemented is that k8s will use ipv6 addresses instead of ipv4, you don't have to turn on anything,

@aojea Ack thanks. I am ok with just one cloud provider in that case for beta.

BenTheElder · 2019-07-26T17:50:12Z

keps/sig-network/20190714-IPv6-beta-proposal.md

+
+* Make kind IPv6 e2e jobs mandatory for all PRs
+* Create IPv6 e2e jobs on at least 2 Cloud Providers and publish the results on testgrid
+* Move all IPv6 e2e conformance jobs (kind + Cloud Providers) into release blocking


(following the standard process to move things into blocking following proving that they are stable and contacting SIG-release of course)

Ok, thanks, will reword and explain it better

lachie83 · 2019-07-27T13:38:05Z

cc @khenidak

dims · 2019-07-29T12:26:11Z

/assign @johnbelamaric @thockin

keps/sig-network/20190714-IPv6-beta-proposal.md

thockin

Thanks!

/lgtm
/approve

k8s-ci-robot · 2019-08-09T23:47:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~keps/sig-network/OWNERS~~ [thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/network Categorizes an issue or PR as relevant to SIG Network. labels Jul 14, 2019

k8s-ci-robot requested review from caseydavenport and thockin July 14, 2019 20:53

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 14, 2019

aojea mentioned this pull request Jul 14, 2019

IPv6 only support #1138

Closed

k8s-ci-robot requested review from BenTheElder and lachie83 July 14, 2019 20:56

aojea changed the title ~~Graduate IPv6 support to beta~~ [WIP] Graduate IPv6 support to beta Jul 20, 2019

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2019

aojea mentioned this pull request Jul 20, 2019

E2Es for hostport/HostIP resolution to conformance does not support IPv6 kubernetes/kubernetes#80388

Closed

aojea force-pushed the ipv6Beta branch 2 times, most recently from 4cb2f23 to 8d625ce Compare July 23, 2019 13:52

aojea changed the title ~~[WIP] Graduate IPv6 support to beta~~ Graduate IPv6 support to beta Jul 23, 2019

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 23, 2019

aojea force-pushed the ipv6Beta branch 4 times, most recently from f926d20 to 4be84c3 Compare July 23, 2019 21:52

Create 20190714-IPv6-beta-proposal.md

6204729

aojea force-pushed the ipv6Beta branch from 4be84c3 to 6204729 Compare July 23, 2019 22:02

aojea commented Jul 24, 2019

View reviewed changes

keps/sig-network/20190714-IPv6-beta-proposal.md Outdated Show resolved Hide resolved

aojea commented Jul 26, 2019

View reviewed changes

dims reviewed Jul 26, 2019

View reviewed changes

BenTheElder reviewed Jul 26, 2019

View reviewed changes

aojea force-pushed the ipv6Beta branch from 4898287 to 6bc3ea8 Compare July 27, 2019 15:47

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 27, 2019

aojea force-pushed the ipv6Beta branch from 6bc3ea8 to 0b478a4 Compare July 27, 2019 15:53

Address feedback on cloud providers

9a748e9

aojea force-pushed the ipv6Beta branch from 0b478a4 to 9a748e9 Compare July 28, 2019 14:02

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 28, 2019

k8s-ci-robot assigned johnbelamaric and thockin Jul 29, 2019

aojea commented Jul 29, 2019

View reviewed changes

keps/sig-network/20190714-IPv6-beta-proposal.md Show resolved Hide resolved

danehans mentioned this pull request Jul 31, 2019

IPv6 support added #508

Closed

This was referenced Aug 2, 2019

Add IPv6 support to kubenet hostport kubernetes/kubernetes#80854

Merged

IPv6 only kubernetes cluster Azure/aks-engine#1729

Closed

thockin reviewed Aug 9, 2019

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2019

k8s-ci-robot merged commit df77bac into kubernetes:master Aug 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Graduate IPv6 support to beta #1139

Graduate IPv6 support to beta #1139

aojea commented Jul 14, 2019 •

edited

Loading

aojea commented Jul 14, 2019

aojea commented Jul 20, 2019 •

edited

Loading

dims commented Jul 20, 2019

aojea commented Jul 22, 2019

aojea Jul 26, 2019

BenTheElder Jul 26, 2019

dims Jul 26, 2019

BenTheElder Jul 26, 2019

dims Jul 26, 2019

dims Jul 26, 2019

aojea Jul 26, 2019

dims Jul 26, 2019

aojea Jul 26, 2019 •

edited

Loading

dims Jul 26, 2019

BenTheElder Jul 26, 2019

aojea Jul 26, 2019

lachie83 commented Jul 27, 2019

dims commented Jul 29, 2019

thockin left a comment

k8s-ci-robot commented Aug 9, 2019

Graduate IPv6 support to beta #1139

Graduate IPv6 support to beta #1139

Conversation

aojea commented Jul 14, 2019 • edited Loading

aojea commented Jul 14, 2019

aojea commented Jul 20, 2019 • edited Loading

dims commented Jul 20, 2019

aojea commented Jul 22, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aojea Jul 26, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lachie83 commented Jul 27, 2019

dims commented Jul 29, 2019

thockin left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Aug 9, 2019

aojea commented Jul 14, 2019 •

edited

Loading

aojea commented Jul 20, 2019 •

edited

Loading

aojea Jul 26, 2019 •

edited

Loading