Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release-notes KEP to reflect the current state #1807

Merged
merged 1 commit into from Sep 11, 2020

Conversation

saschagrunert
Copy link
Member

This update for the release notes KEP should layout the current state of
the implementation.

Refers to #1733

/cc @puerco @justaugustus @jeefy

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/release Categorizes an issue or PR as relevant to SIG Release. labels May 25, 2020
@puerco
Copy link
Member

puerco commented May 25, 2020

@saschagrunert thanks for the PR. I think your changes capture most of the current direction I understand the project to be taking. There are three different areas we could address when thinking about the KEP:

  1. Updating general design issues to where they are now and where they are heading. I think you already mentioned most of them.
  2. Addressing those areas where the original ideas from @jeefy 's KEP have already been implemented.
  3. Future plans and direction

Here's what I think about those three items:

  1. As I said before, I think your changes reflect the current design well, those areas that have shifted from a year ago when the KEP was written.
  2. Regarding the actual implementation, I like your checklist because it shows what has been implemented without altering the KEP much.
    If we are trying to reflecting the current progress of the implementation in the KEP itself, there are other areas we ought to note as well. For example, the fact that the website is already up, with it's own domain and out of the personal repo.
  3. Finally, there are the plans that lie ahead of us (as of 2020). I think we are due for a good talk on the focus of the tools and how they are used. Mostly derived from the current status of the code but also from the human/organizational side of things.

But perhaps this last point should left out of the KEP. After all, the original intent of the KEP was this:

this KEP would graduate once we have a dedicated release notes website that is automatically updated with minimal human interaction.

And we are at the brink of that. In fact, if we were to leave out the scope of the KEP the bucket issue we could say that the original mission of the KEP has already been fulfilled already as it only takes one command to go from nothing to the PR that updates the website.

What do you think ?

@saschagrunert
Copy link
Member Author

  1. Future plans and direction

I'm wondering if this should be part of a new KEP.

And we are at the brink of that. In fact, if we were to leave out the scope of the KEP the bucket issue we could say that the original mission of the KEP has already been fulfilled already as it only takes one command to go from nothing to the PR that updates the website.

What do you think ?

Sounds good! If @justaugustus and @jeefy agrees to, then we could mark this KEP as finished and create a new one on top of that. Was that your intention?

@justaugustus
Copy link
Member

/assign @justaugustus
Will review this week.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 24, 2020
@saschagrunert
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 24, 2020
@justaugustus
Copy link
Member

@saschagrunert -- can you look over this and let me know if it's still up-to-date?

@saschagrunert
Copy link
Member Author

@saschagrunert -- can you look over this and let me know if it's still up-to-date?

Should be still fine from my viewpoint. The enhancements @puerco was planning were explicitly kept out of this KEP.

Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few updates before we merge.

keps/sig-release/1733-release-notes/README.md Outdated Show resolved Hide resolved
keps/sig-release/1733-release-notes/README.md Outdated Show resolved Hide resolved
keps/sig-release/1733-release-notes/README.md Outdated Show resolved Hide resolved
keps/sig-release/1733-release-notes/kep.yaml Outdated Show resolved Hide resolved
This update for the release notes KEP should layout the current state of
the implementation.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2020
@justaugustus
Copy link
Member

Thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8d7447d into kubernetes:master Sep 11, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 11, 2020
@saschagrunert saschagrunert deleted the relnotes-kep-update branch September 11, 2020 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants