priority and fairness: add production readiness review #2049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
requested review from
ahg-g,
lavalamp,
MikeSpreitzer and
wojtek-t
k8s-ci-robot
added
sig/api-machinery
k8s-ci-robot
added
size/L
wojtek-t
reviewed
Oct 2, 2020
adtac
force-pushed
the
apfprr
branch
2 times, most recently
from
253181d
to
308e3a5
Compare
|
/lgtm @lavalamp - for approval |
k8s-ci-robot
added
the
lgtm
lavalamp
reviewed
Oct 6, 2020
k8s-ci-robot
removed
the
lgtm
adtac
force-pushed
the
apfprr
branch
2 times, most recently
from
df38283
to
e17fe09
Compare
|
/lgtm @lavalamp - for approval |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
|
ping @wojtek-t for another LGTM -- one minor change since your last LGTM: as per Mike's comments, amended the answer to the question on how to enable/disable this feature. |
|
also ping @lavalamp for approval |
lavalamp
reviewed
Oct 14, 2020
lavalamp
reviewed
Oct 14, 2020
|
Just needs a couple fixes around what happens if you misconfigure, then it's good to go. |
Signed-off-by: Adhityaa Chandrasekar <adtac@google.com>
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adtac, lavalamp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've filled in most of the questions in the PRR to the best of my (limited) knowledge -- please take a look and let me know if there are corrections to be made. I don't know enough to answer some of the questions - I'd appreciate your input on some of these questions.
/sig api-machinery
/cc @lavalamp @wojtek-t @ahg-g @MikeSpreitzer