Updating topology KEPs to reflect updated 1.21 alpha target #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
size/S
k8s-ci-robot
added
the
sig/network
seh
reviewed
Nov 14, 2020
| @@ -183,6 +183,11 @@ between expected endpoints and actual endpoints in the zone). | |||
| - Autoscaling will not behave well if only a single zone is receiving large | |||
| amounts of traffic. This could potentially be mitigated by separating | |||
| deployments and HPAs per zone. | |||
| - Services with ExternalTrafficPolicy=local will need special treatment here. | |||
There was a problem hiding this comment.
Suggested change
| - Services with ExternalTrafficPolicy=local will need special treatment here. | |
| - Services with ExternalTrafficPolicy=Local will need special treatment here. |
seh
reviewed
Nov 14, 2020
| @@ -535,8 +540,9 @@ EPEachZonePerSync = metrics.NewHistogramVec( | |||
| ### Graduation Criteria | |||
| - Alpha should provide basic functionality covered with tests described above. | |||
| - This KEP will largely depend on the EndpointSlice Subsetting. Once the | |||
| EndpointSlice Subsetting feature has been updated, our change can kick-in | |||
| without any new fields being added. | |||
| EndpointSlice Subsetting feature has been updated, our change can kick-in | |||
There was a problem hiding this comment.
Suggested change
| EndpointSlice Subsetting feature has been updated, our change can kick-in | |
| EndpointSlice Subsetting feature has been updated, our change can kick in |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds some notes about node local traffic and DNS.
/assign @thockin