dualstack kep updates #2325
dualstack kep updates #2325
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
kind/kep
k8s-ci-robot
added
size/M
khenidak
force-pushed
the
kep-updates
branch
2 times, most recently
from
b29fa46
to
a1f410d
Compare
khenidak
force-pushed
the
kep-updates
branch
3 times, most recently
from
b6c0ed5
to
9d0886a
Compare
k8s-ci-robot
added
size/L
| - Non-headless Kubernetes services: CoreDNS will resolve these services to | ||
| either an IPv4 entry (A record) or an IPv6 entry (AAAA record), depending | ||
| upon the IP family of the cluster's service CIDR. | ||
| - Headless Kubernetes services: CoreDNS will resolve these services to either | ||
| an IPv4 entry (A record), an IPv6 entry (AAAA record), or both, depending on | ||
| the service's `ipFamily`. | ||
| - Once Kubernetes service (pointing to Cluster DNS) is converted to dualstack pods |
There was a problem hiding this comment.
Is this true? I don't recall reviewing that part?
There was a problem hiding this comment.
yes. we updated both downward api and resolv.conf
There was a problem hiding this comment.
Hmmm I'm not sure about this same as Tim says ...
There was a problem hiding this comment.
it wasn't resolv conf, it was downward api and /etc/hosts :)
kubernetes/kubernetes#83123
The resolv.conf is single stack and is populated by kubelet, I think that we discussed it in some PR but it never got dualstacked (IIRC)
|
|
||
| * **Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?** | ||
| Describe manual testing that was done and the outcomes. | ||
| Longer term, we may want to require automated upgrade/rollback tests, but we |
There was a problem hiding this comment.
I did manual testing of a cluster turning it off and on to explore disabled-with-data behavior. This item specifically talks about manual testing, so maybe we should just do some more of that to build confidence
|
|
||
| * **Is the rollout accompanied by any deprecations and/or removals of features, APIs, | ||
| fields of API types, flags, etc.?** | ||
| Even if applying deprecation policies, they may still surprise some users. |
| employ dual-stack. This can be done via | ||
|
|
||
| ``` | ||
| kubectl get services --all-namespaces spec.ipFamilyPolicy!=SingleStack |
There was a problem hiding this comment.
this commandline doesn't work? I'd expect something like:
kubectl get services --all-namespaces -ogo-template='{{range .items}}{{.spec.ipFamilyPolicy}}{{"\n"}}{{end}}'
with some if in there or some post-processing pipeline
| ### Dependencies | ||
|
|
||
| * **Does this feature depend on any specific services running in the cluster?** | ||
| Think about both cluster-level services (e.g. metrics-server) as well |
There was a problem hiding this comment.
We should remove all of the template's text and just leave our answers
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khenidak, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Minor updates to dual stack kep