Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to KEP-3329 "Retriable and non-retriable Pod failures for Jobs" #3452

Merged
merged 1 commit into from Aug 9, 2022
Merged

Updates to KEP-3329 "Retriable and non-retriable Pod failures for Jobs" #3452

merged 1 commit into from Aug 9, 2022

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Aug 2, 2022 •
edited

  • One-line PR description: Updates to the KEP-3329 for Alpha

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 2, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @mimowo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 2, 2022
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Aug 2, 2022
@mimowo mimowo force-pushed the retriable-exit-codes-additional-update2 branch from 097ff3d to 25a2c5a Compare August 2, 2022 10:35
@mimowo
Copy link
Contributor Author

mimowo commented Aug 2, 2022

/test

@k8s-ci-robot
Copy link
Contributor

@mimowo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mimowo mimowo force-pushed the retriable-exit-codes-additional-update2 branch from 25a2c5a to 182378a Compare August 3, 2022 07:32
@mimowo mimowo mentioned this pull request Aug 3, 2022
Merged
@mimowo mimowo force-pushed the retriable-exit-codes-additional-update2 branch from 182378a to 5b5724b Compare August 3, 2022 13:47
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 3, 2022
@mimowo mimowo force-pushed the retriable-exit-codes-additional-update2 branch 3 times, most recently from 6dbef38 to 351f683 Compare August 4, 2022 09:32
@mimowo mimowo changed the title Updates to KEP-3329 "Retriable and non-retriable Pod failures for Jobs" for Alpha Updates to KEP-3329 "Retriable and non-retriable Pod failures for Jobs" Aug 4, 2022
@mimowo mimowo marked this pull request as ready for review August 4, 2022 09:33
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 4, 2022
@mimowo
Copy link
Contributor Author

mimowo commented Aug 4, 2022

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@mimowo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mimowo mimowo force-pushed the retriable-exit-codes-additional-update2 branch 2 times, most recently from 8da028e to c7b8b97 Compare August 4, 2022 15:01
@alculquicondor
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 4, 2022
@mimowo mimowo force-pushed the retriable-exit-codes-additional-update2 branch from c7b8b97 to 274b937 Compare August 5, 2022 08:11
@mimowo mimowo force-pushed the retriable-exit-codes-additional-update2 branch from 274b937 to 0c92bec Compare August 5, 2022 08:22
@alculquicondor alculquicondor mentioned this pull request Aug 5, 2022
Open
8 tasks
@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2022
soltysh
soltysh approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6e87729 into kubernetes:master Aug 9, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 9, 2022
@mimowo mimowo deleted the retriable-exit-codes-additional-update2 branch March 18, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@kow3ns kow3ns Awaiting requested review from kow3ns

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mimowo @k8s-ci-robot @alculquicondor @soltysh