Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promote ServiceIPStaticSubrange to GA #3578

Closed
wants to merge 1 commit into from
Closed

promote ServiceIPStaticSubrange to GA #3578

wants to merge 1 commit into from

Conversation

aojea
Copy link
Member

@aojea aojea commented Oct 4, 2022

  • One-line PR description:

promote ServiceIPStaticSubrange to GA

  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 4, 2022
@aojea
Copy link
Member Author

aojea commented Oct 4, 2022

/assign @thockin @wojtek-t

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/network Categorizes an issue or PR as relevant to SIG Network. labels Oct 4, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 4, 2022
@aojea
promote ServiceIPStaticSubrange to GA
d191978 
Signed-off-by: Antonio Ojea <antonio.ojea.garcia@gmail.com>
@aojea aojea mentioned this pull request Oct 4, 2022
Closed
@aojea
Copy link
Member Author

aojea commented Oct 4, 2022

wrong branch

@aojea aojea closed this Oct 4, 2022
@aojea aojea reopened this Oct 4, 2022
@thockin
Copy link
Member

thockin commented Oct 4, 2022

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aojea, thockin
Once this PR has been reviewed and has the lgtm label, please ask for approval from wojtek-t by writing /assign @wojtek-t in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrbobbytables
Copy link
Member

/assign
To get on my radar to clean up the branch after merge

wojtek-t
wojtek-t reviewed Oct 5, 2022
View reviewed changes
keps/prod-readiness/sig-network/3070.yaml
@@ -3,3 +3,5 @@ alpha:
approver: "@wojtek-t"
beta:
approver: "@johnbelamaric"
stable:
approver: "@wojtek-t"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments to the PRR:

L361: "will be expanded with a new label" - has that happened?

L372: can you please fill in the question about upgrade/downgrade testing?
Given it's purely in-memory feature the upgrdae/downgrade doesn't really change anything, but let's just put that into text there.

L374: Please just add "no" :)

L377: "will be expanded" - has that happened?

L:390: "metric will be added" - has that happend?

L412: nit: mark this choice with [X]

L417, L422: can you please fill this in (you already kind of touched on that above)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L361, yes https://github.com/kubernetes/kubernetes/blame/master/pkg/registry/core/service/ipallocator/metrics.go#L63

L372 done

L377 yes

L390 no, it had to be removed kubernetes/kubernetes#106792 (comment)

L412 no new metric was added at the end, only new label for current metrics

L417, L422 the feature doesn't need it, the SLO/SLIs should be about ServiceIP allocations, but that depend on the allocator not on how it allocates, no?

@aojea
Copy link
Member Author

aojea commented Oct 5, 2022

closing to avoid pushing to the repo directly

@aojea aojea closed this Oct 5, 2022
@aojea
Copy link
Member Author

aojea commented Oct 5, 2022

continuing on #3583 to avoid pushing directly to the repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t wojtek-t left review comments

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

@thockin thockin Awaiting requested review from thockin

Assignees

@thockin thockin

@mrbobbytables mrbobbytables

@wojtek-t wojtek-t

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aojea @thockin @k8s-ci-robot @mrbobbytables @wojtek-t