Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-1731: Extend the KEP with the OBS implementation #3750

Merged
merged 9 commits into from Feb 28, 2023
Merged

KEP-1731: Extend the KEP with the OBS implementation #3750

merged 9 commits into from Feb 28, 2023

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Jan 18, 2023

/assign @saschagrunert @cpanato @puerco @Verolop @jeremyrickard @justaugustus
cc @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 18, 2023
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jan 18, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 18, 2023
@xmudrii xmudrii force-pushed the kep-1731-obs branch 2 times, most recently from 1405ba3 to 68cc229 Compare January 18, 2023 10:20
saschagrunert
saschagrunert approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2023
@xmudrii xmudrii mentioned this pull request Jan 18, 2023
Open
49 tasks
@saschagrunert saschagrunert mentioned this pull request Jan 20, 2023
Closed
@xmudrii xmudrii requested review from saschagrunert and Conan-Kudo and removed request for Conan-Kudo January 24, 2023 14:44
@xmudrii
Copy link
Member Author

xmudrii commented Jan 24, 2023

@saschagrunert @Conan-Kudo I updated based on the feedback from the OBS team. Please take a look again and let me know if this is okay.

Conan-Kudo
Conan-Kudo approved these changes Jan 24, 2023
View reviewed changes
Copy link

@Conan-Kudo Conan-Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo the current open discussion that has @shaunix pinged, looks great.

aojea
aojea reviewed Jan 25, 2023
View reviewed changes
keps/sig-release/1731-publishing-packages/README.md
- Additional efforts would be needed to get reproducible builds working
- We would also lose cosign signatures for binaries built by OBS

`kubepkg` will be extended with a subcommand to create a tarball with all required binaries and files (e.g. systemd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there has to be some kind of integrity check, no?

@xmudrii
Add PRR yaml
35ee8bd 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2023
@xmudrii
Update KEP based on the recent feedback
327dbf7 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Copy link
Member Author

xmudrii commented Feb 15, 2023

All the comments should be addressed now as part of 327dbf7

@kubernetes/sig-release-leads @kubernetes/release-engineering @dirkmueller @darix @adrianschroeter Please take a look at the recent update.

@johnbelamaric
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2023
@ameukam
Copy link
Member

ameukam commented Feb 22, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2023
saschagrunert
saschagrunert approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's lift the hold next Tuesday to give everyone a bit room for another round of review.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Conan-Kudo, johnbelamaric, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Conan-Kudo
Conan-Kudo reviewed Feb 23, 2023
View reviewed changes
keps/sig-release/1731-publishing-packages/README.md

#### Ownership of OBS infrastructure and commitments

Packages will be hosted, published, and served from the [OpenBuildService instance hosted and maintained by SUSE][obs-build]. The instance is under the full ownership and control of SUSE. SUSE provide us:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenBuildService -> Open Build Service

@jimangel
Copy link
Member

I have open comments but don't consider them blocking, feel free to resolve @xmudrii! Thanks!

/lgtm

@saschagrunert
Copy link
Member

/unhold

We met the Tuesday deadline for feedback.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit ff049f0 into kubernetes:master Feb 28, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Feb 28, 2023
@xmudrii xmudrii deleted the kep-1731-obs branch February 28, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darix darix darix left review comments

@Conan-Kudo Conan-Kudo Conan-Kudo approved these changes

@mlschroe mlschroe mlschroe left review comments

@adrianschroeter adrianschroeter adrianschroeter left review comments

@ameukam ameukam ameukam left review comments

@hlovdal hlovdal hlovdal left review comments

@jimangel jimangel jimangel left review comments

@aojea aojea aojea left review comments

@jeremyrickard jeremyrickard jeremyrickard left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

@puerco puerco Awaiting requested review from puerco

@dirkmueller dirkmueller Awaiting requested review from dirkmueller

Assignees

@justaugustus justaugustus

@saschagrunert saschagrunert

@Verolop Verolop

@ameukam ameukam

@puerco puerco

@cpanato cpanato

@jimangel jimangel

@johnbelamaric johnbelamaric

@jeremyrickard jeremyrickard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet