Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sig-auth release notes: add advanced audit to action required, add selfsubjectrulesreview #412

Merged
merged 1 commit into from
Sep 1, 2017

Conversation

ericchiang
Copy link
Contributor

@ericchiang ericchiang commented Sep 1, 2017

Add notes about advanced auditing changes. cc @sttts @CaoShuFeng @soltysh

kubernetes/kubernetes#48051 has been approved, so adding it here.

/cc @radhikapc

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 1, 2017
Copy link
Contributor

@radhikapc radhikapc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor change, otherwise lgtm.

`v1beta1` event format, the log file defaults to JSON encoding, and the
`--audit-policy-file` requires `kind` and `apiVersion` fields specifying
what format version the `Policy` is using.

Copy link
Contributor

@radhikapc radhikapc Sep 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Advanced auditing has graduated from v1alpha1 to v1beta1 with the following changes to the default behavior:

  • Webhook and the log file now output the v1beta1 event format
  • The log file defaults to JSON encoding
  • The --audit-policy-file requires kind and apiVersion fields specifying what format and version the Policy is using

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 1, 2017
Copy link
Contributor

@radhikapc radhikapc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@radhikapc radhikapc merged commit b42ac5f into kubernetes:master Sep 1, 2017
@ericchiang ericchiang deleted the more-auth-notes branch September 1, 2017 18:23
justaugustus pushed a commit to justaugustus/enhancements that referenced this pull request Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants