Graduate NewVolumeManagerReconstruction GA #4432
Merged
+30
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
kind/kep
k8s-ci-robot
added
size/M
jsafrane
force-pushed
the
reconstruction-ga
branch
from
3dbdeae
to
6de765a
Compare
k8s-ci-robot
removed
the
approved
jsafrane
force-pushed
the
reconstruction-ga
branch
from
6de765a
to
fd55da6
Compare
8 tasks
jsafrane
force-pushed
the
reconstruction-ga
branch
from
fd55da6
to
43f8ce9
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Can you resolve the merge conflict? |
k8s-ci-robot
added
the
needs-rebase
jsafrane
force-pushed
the
reconstruction-ga
branch
from
43f8ce9
to
b510823
Compare
k8s-ci-robot
removed
lgtm
|
Rebased |
|
/assign @deads2k |
soltysh
reviewed
Feb 6, 2024
| @@ -769,7 +772,7 @@ Longer term, we may want to require automated upgrade/rollback tests, but we | |||
| are missing a bunch of machinery and tooling and can't do that now. | |||
| --> | |||
|
|
|||
| Not yet. This will be a manual test. | |||
| Yes, see https://github.com/kubernetes/enhancements/issues/3756#issuecomment-1906255361 (and expand `Details`). | |||
There was a problem hiding this comment.
Minor nit, can we just copy that data here, for lazy people like myself 😉
|
PRR looks good. /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link: Robust VolumeManager reconstruction after kubelet restart #3756
Update to a new KEP template (one extra PRR question).
Update what has been done.
cc @msau42