Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRA: update structured parameters KEP to match API in 1.30 #4561

Merged
merged 1 commit into from Apr 16, 2024
Merged

DRA: update structured parameters KEP to match API in 1.30 #4561

merged 1 commit into from Apr 16, 2024

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Mar 27, 2024

/cc @mrunalp

Here's the KEP update we discussed in kubernetes/kubernetes#123516 (comment).

/cc @klueska

Can you review?

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 27, 2024
@pohly pohly mentioned this pull request Mar 27, 2024
Merged
klueska
klueska reviewed Apr 2, 2024
View reviewed changes
Copy link
Contributor

@klueska klueska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick pass. My only question is if we want to also fix the example CEL expressions to match how they actually look. The current examples in the KEP are incorrect.

keps/sig-node/4381-dra-structured-parameters/README.md Outdated Show resolved Hide resolved
keps/sig-node/4381-dra-structured-parameters/README.md Show resolved Hide resolved
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Apr 3, 2024
@pohly
Copy link
Contributor Author

pohly commented Apr 3, 2024

fix the example CEL expressions to match how they actually look

Yes, let's do that in this PR.

@pohly
DRA: update structured parameters KEP to match API in 1.30
5434fff 
Several changes to the API were made during the implementation phase.
klueska
klueska reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor

@klueska klueska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2024
@pohly
Copy link
Contributor Author

pohly commented Apr 5, 2024

/assign @dchen1107

For KEP approval.

@pohly
Copy link
Contributor Author

pohly commented Apr 5, 2024

/priority important-soon

Let's merge this so that we can continue to update the DRA KEP(s).

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 5, 2024
@mrunalp
Copy link
Contributor

mrunalp commented Apr 16, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klueska, mrunalp, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klueska, mrunalp, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 603a1f1 into kubernetes:master Apr 16, 2024
4 checks passed
SIG Node PR Triage automation moved this from Needs Reviewer to Done Apr 16, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klueska klueska klueska left review comments

@mrunalp mrunalp mrunalp approved these changes

Assignees

@klueska klueska

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Node PR Triage
Done
SIG Node: Dynamic Resource Allocation
Status: ✅ Done
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pohly @mrunalp @k8s-ci-robot @klueska @dchen1107