Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify HA Setup for Master #48

Closed
22 tasks
aronchick opened this issue Jul 22, 2016 · 27 comments
Closed
22 tasks

Simplify HA Setup for Master #48

aronchick opened this issue Jul 22, 2016 · 27 comments
Assignees
Labels
sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.

Comments

@aronchick
Copy link
Contributor

aronchick commented Jul 22, 2016

Description

Simplify setup for HA Master. Description in kubernetes/kubernetes#29649

Progress Tracker

  • Before Alpha
    • Write and maintain draft quality doc
      • During development keep a doc up-to-date about the desired experience of the feature and how someone can try the feature in its current state. Think of it as the README of your new feature and a skeleton for the docs to be written before the Kubernetes release. Paste link to Google Doc: DOC-LINK
    • Design Approval
      • Design Proposal. This goes under docs/proposals. Doing a proposal as a PR allows line-by-line commenting from community, and creates the basis for later design documentation. Paste link to merged design proposal here: PROPOSAL-NUMBER
      • Initial API review (if API). Maybe same PR as design doc. PR-NUMBER
        • Any code that changes an API (/pkg/apis/...)
        • cc @kubernetes/api
      • Identify shepherd (your SIG lead and/or kubernetes-pm@googlegroups.com will be able to help you). My Shepherd is: replace.me@replaceme.com (and/or GH Handle)
        • A shepherd is an individual who will help acquaint you with the process of getting your feature into the repo, identify reviewers and provide feedback on the feature. They are not (necessarily) the code reviewer of the feature, or tech lead for the area.
        • The shepherd is not responsible for showing up to Kubernetes-PM meetings and/or communicating if the feature is on-track to make the release goals. That is still your responsibility.
      • Identify secondary/backup contact point. My Secondary Contact Point is: replace.me@replaceme.com (and/or GH Handle)
    • Write (code + tests + docs) then get them merged. ALL-PR-NUMBERS
      • Code needs to be disabled by default. Verified by code OWNERS
      • Minimal testing
      • Minimal docs
        • cc @kubernetes/docs on docs PR
        • cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
        • New apis: Glossary Section Item in the docs repo: kubernetes/kubernetes.github.io
      • Update release notes
  • Before Beta
    • Testing is sufficient for beta
    • User docs with tutorials
      • Updated walkthrough / tutorial in the docs repo: kubernetes/kubernetes.github.io
      • cc @kubernetes/docs on docs PR
      • cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
    • Thorough API review
      • cc @kubernetes/api
  • Before Stable
    • docs/proposals/foo.md moved to docs/design/foo.md
      • cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
    • Soak, load testing
    • detailed user docs and examples
      • cc @kubernetes/docs
      • cc @kubernetes/feature-reviewers on this issue to get approval before checking this off

FEATURE_STATUS is used for feature tracking and to be updated by @kubernetes/feature-reviewers.
FEATURE_STATUS: IN_DEVELOPMENT

More advice:

Design

  • Once you get LGTM from a @kubernetes/feature-reviewers member, you can check this checkbox, and the reviewer will apply the "design-complete" label.

Coding

  • Use as many PRs as you need. Write tests in the same or different PRs, as is convenient for you.
  • As each PR is merged, add a comment to this issue referencing the PRs. Code goes in the http://github.com/kubernetes/kubernetes repository,
    and sometimes http://github.com/kubernetes/contrib, or other repos.
  • When you are done with the code, apply the "code-complete" label.
  • When the feature has user docs, please add a comment mentioning @kubernetes/feature-reviewers and they will
    check that the code matches the proposed feature and design, and that everything is done, and that there is adequate
    testing. They won't do detailed code review: that already happened when your PRs were reviewed.
    When that is done, you can check this box and the reviewer will apply the "code-complete" label.

Docs

  • Write user docs and get them merged in.
  • User docs go into http://github.com/kubernetes/kubernetes.github.io.
  • When the feature has user docs, please add a comment mentioning @kubernetes/docs.
  • When you get LGTM, you can check this checkbox, and the reviewer will apply the "docs-complete" label.
@aronchick aronchick added this to the v1.4 milestone Jul 22, 2016
@idvoretskyi
Copy link
Member

idvoretskyi commented Jul 25, 2016

cc @kubernetes/sig-cluster-lifecycle @sig-clusterops

@timothysc
Copy link
Member

What exactly are we aiming to do here? We haven't cited the series of issues that @mikedanese and I created a while ago and the description doesn't exist.

@fgrzadkowski
Copy link

The idea is to automate setting up HA master in OSS. We will use kube-up.sh for GCE for that.

@philips
Copy link
Contributor

philips commented Jul 26, 2016

@timothysc can you gather up those issues and we can update the issue body?

@fgrzadkowski can you and @jszczepkowski work to create a more useful body?

@errordeveloper
Copy link
Member

Yes, please, it would be great to see it all in one place. Also, lately I
had been thinking about what HA control plane bootstrap/discovery API could
look like.

On Tue, 26 Jul 2016, 23:58 Brandon Philips, notifications@github.com
wrote:

@timothysc https://github.com/timothysc can you gather up those issues
and we can update the issue body?

@fgrzadkowski https://github.com/fgrzadkowski can you and @jszczepkowski
https://github.com/jszczepkowski work to create a more useful body?


You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
#48 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPWS9uZ1w56419trvVWG4Tbh0OqlRPtks5qZpEhgaJpZM4JTH5P
.

@fgrzadkowski
Copy link

I've just sent PR with design for this feature in kubernetes/kubernetes#29649. Please see what's missing.

@timothysc
Copy link
Member

All backlog'd items have been labeled: https://github.com/kubernetes/kubernetes/labels/area%2FHA

@alex-mohr
Copy link

@davidopp thinks this is unlikely to make it.

@alex-mohr alex-mohr modified the milestones: v1.5, v1.4 Aug 17, 2016
@davidopp
Copy link
Member

Yeah, definitely not going to make it.

@idvoretskyi
Copy link
Member

@jszczepkowski @alex-mohr @davidopp is this feature actively developed? Can we expect it to be present in 1.5?

@fgrzadkowski
Copy link

Yes it is actively developed. We should make it for 1.5.

@jaredbhatti
Copy link

Ping. Is there a docs PR for this?

@jszczepkowski
Copy link

Docs PR is here: kubernetes/website#1810

@spiffxp
Copy link
Member

spiffxp commented Dec 1, 2016

I'm removing the team/SIG-ClusterLifecycle label given that SIG-ClusterOps is listed as the owner in the 1.5 feature spreadsheet; if we're using labels to describe areas of overlap then we need something else in these issues to identify owner

@spiffxp spiffxp removed the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Dec 1, 2016
@timothysc
Copy link
Member

nope nope, switching that back.

@timothysc timothysc added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Dec 1, 2016
@jszczepkowski
Copy link

I've created a doc describing potential etcd/master replica failure scenarios that shall be manually tested. Everybody is invited to review it.

@idvoretskyi
Copy link
Member

@aronchick @jszczepkowski can you confirm that this item targets beta in 1.6?

@idvoretskyi idvoretskyi modified the milestones: next-milestone, v1.5 Dec 13, 2016
@idvoretskyi
Copy link
Member

@aronchick @jszczepkowski any progress for 1.7 is expected for this feature?

@timothysc
Copy link
Member

We will write an updated proposal for kubeadm deployments in the 1.7 cycle.
/cc @kubernetes/sig-cluster-lifecycle-misc

@philips
Copy link
Contributor

philips commented Apr 12, 2017

@jszczepkowski that doc isn't public

@philips
Copy link
Contributor

philips commented Apr 12, 2017

@timothysc please add me on any proposal. I really think that a self-hosted etcd model using the etcd Operator here can address a number of the concerns and simplify the deployment, maintenance, and failure-domain burden for the user.

For example see my demos from KubeCon

cc @hongchaodeng @xiang90

@timothysc
Copy link
Member

There is a draft up for comment, and we'll hash out a more formal proposal with the SIG.

https://docs.google.com/document/d/1lH9OKkFZMSqXCApmSXemEDuy9qlINdm5MfWWGrK3JYc/edit#

@apsinha
Copy link

apsinha commented May 4, 2017

@jbeda is SIG lifecycle targeting this feature for 1.7? It is not in the features repo but perhaps was part of your SIG's planning so PM SIG wanted to check in.

@timothysc
Copy link
Member

@apsinha We're planning to complete our draft proposal and might begin execution on some elements, but we are not delivering a full solution for this cycle.

@luxas
Copy link
Member

luxas commented Oct 27, 2017

@roberthbailey should we close this in favor for the more specialized #357?
This seems more GCE-specific...

@roberthbailey
Copy link
Contributor

I agree. This feature was to track adding HA support to kube-up.sh. That is done, but since kube-up is deprecated we aren't planning to graduate the implementation beyond it's current support level.

@roberthbailey roberthbailey removed this from the next-milestone milestone Oct 27, 2017
ingvagabund pushed a commit to ingvagabund/enhancements that referenced this issue Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
Projects
None yet
Development

No branches or pull requests